Skip to content

ResourceCleanupService test fix for daylight saving time#10749

Merged
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:ResourceCleanupService_test_fix_for_dst
Apr 30, 2025
Merged

ResourceCleanupService test fix for daylight saving time#10749
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:ResourceCleanupService_test_fix_for_dst

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Apr 17, 2025

Description

This PR fixes ResourceCleanupService test for daylight saving time.

Fixes #10666

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Verified updated test.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti marked this pull request as ready for review April 17, 2025 16:13
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Apr 17, 2025

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.20.1 milestone Apr 17, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 17, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.02%. Comparing base (199170b) to head (cfe50c0).
Report is 27 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10749   +/-   ##
=========================================
  Coverage     16.02%   16.02%           
- Complexity    13126    13131    +5     
=========================================
  Files          5652     5652           
  Lines        495998   495998           
  Branches      60067    60067           
=========================================
+ Hits          79477    79491   +14     
+ Misses       407653   407638   -15     
- Partials       8868     8869    +1
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 16.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache
weizhouapache approved these changes Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test passed when days is 10 or 20.

another option could be

cal.setTimeZone(TimeZone.getTimeZone("UTC"));

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 17, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13102

Pearl1594
Pearl1594 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

harikrishna-patnala
harikrishna-patnala approved these changes Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 23, 2025

@weizhouapache , you want to merge like this or amend?

@weizhouapache weizhouapache merged commit 030ed55 into apache:4.20 Apr 30, 2025
25 checks passed
@weizhouapache weizhouapache deleted the ResourceCleanupService_test_fix_for_dst branch April 30, 2025 09:23
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@sureshanaparti @dhslove
server/test: ResourceCleanupService test fix for daylight saving time (…
588d511 
…apache#10749)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

6 participants

@sureshanaparti @blueorangutan @DaanHoogland @harikrishna-patnala @Pearl1594 @weizhouapache