Skip to content

2fa: log error on totp mismatch#10734

Merged
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:log-totp-mismatch
Sep 8, 2025
Merged

2fa: log error on totp mismatch#10734
weizhouapache merged 1 commit intoapache:4.20from
shapeblue:log-totp-mismatch

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Apr 16, 2025

Description

Addresses #9515

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
2fa: log error on totp mismatch
150809c 
Addresses apache#9515

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.65%. Comparing base (6850147) to head (150809c).
⚠️ Report is 254 commits behind head on 4.20.

Files with missing lines Patch % Lines
...loudstack/auth/TotpUserTwoFactorAuthenticator.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10734      +/-   ##
============================================
+ Coverage     16.01%   16.65%   +0.64%     
- Complexity    13112    13951     +839     
============================================
  Files          5652     5660       +8     
  Lines        495817   530243   +34426     
  Branches      60045    74479   +14434     
============================================
+ Hits          79404    88335    +8931     
- Misses       407551   432084   +24533     
- Partials       8862     9824     +962
Flag Coverage Δ
uitests 4.41% <ø> (+0.41%) ⬆️
unittests 17.45% <0.00%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr linked an issue Apr 16, 2025 that may be closed by this pull request
2fa session failure after management time sync error #9515
Closed
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Apr 16, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2025

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13073

@yadvr yadvr requested a review from harikrishna-patnala May 9, 2025 05:26
@yadvr yadvr added this to the 4.20.1 milestone May 9, 2025
@yadvr yadvr requested a review from Pearl1594 May 9, 2025 05:27
@shwstppr shwstppr closed this May 16, 2025
@shwstppr shwstppr reopened this Jul 18, 2025
@shwstppr shwstppr marked this pull request as ready for review August 5, 2025 10:55
Pearl1594
Pearl1594 approved these changes Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm.

@shwstppr shwstppr modified the milestones: 4.20.1, 4.20.2 Sep 5, 2025
weizhouapache
weizhouapache approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 8, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache self-assigned this Sep 8, 2025
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 8, 2025

this is simple change with debugging, smoke test is not needed
I will merge when packaging job is done

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14893

harikrishna-patnala
harikrishna-patnala approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weizhouapache weizhouapache merged commit 6868f05 into apache:4.20 Sep 8, 2025
48 of 50 checks passed
@DaanHoogland DaanHoogland deleted the log-totp-mismatch branch September 8, 2025 10:05
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 15, 2025
@shwstppr @dhslove
2fa: log error on totp mismatch (apache#10734)
f65df90 
Addresses apache#9515

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@weizhouapache weizhouapache

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

2fa session failure after management time sync error

6 participants

@shwstppr @blueorangutan @weizhouapache @harikrishna-patnala @Pearl1594 @yadvr