Skip to content

Fix volume migration failure handling#10707

Merged
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:FixVolumeFailureResponse
Apr 16, 2025
Merged

Fix volume migration failure handling#10707
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:FixVolumeFailureResponse

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Apr 14, 2025 •
edited
Loading

Description

This PR fixes #9881 by handling the migrate volume answer result properly.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

  1. Deploy a VM on CloudStack
  2. Stop the VM
  3. Via the vCenter, remove the VM from the inventory - leaving behind the VM's disk
  4. Attempt Volume migration, this operation failed and CS reports the same error.
image

@harikrishna-patnala harikrishna-patnala added this to the 4.20.1 milestone Apr 14, 2025
@harikrishna-patnala harikrishna-patnala linked an issue Apr 14, 2025 that may be closed by this pull request
Vmware: Volume migration of a VM removed from inventory on vCenter is reported as success even though it fails #9881
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 16.01%. Comparing base (dd1c32c) to head (8afac99).
Report is 5 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ck/storage/motion/VmwareStorageMotionStrategy.java 0.00% 16 Missing ⚠️
...oud/hypervisor/vmware/resource/VmwareResource.java 0.00% 2 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10707      +/-   ##
============================================
- Coverage     16.01%   16.01%   -0.01%     
+ Complexity    13114    13111       -3     
============================================
  Files          5652     5652              
  Lines        495844   495851       +7     
  Branches      60046    60047       +1     
============================================
- Hits          79420    79412       -8     
- Misses       407560   407578      +18     
+ Partials       8864     8861       -3
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Apr 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 14, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 14, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 14, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13049

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 15, 2025

@blueorangutan test ol8 vmware-70u3

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 15, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

@kiranchavala kiranchavala self-assigned this Apr 15, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2025

[SF] Trillian test result (tid-12990)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 61276 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10707-t12990-vmware-70u3.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 326.15 test_events_resource.py
test_01_events_resource Error 326.16 test_events_resource.py
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.05 test_list_volumes.py
test_07_list_volumes_listall Failure 0.04 test_list_volumes.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 122.82 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 169.10 test_network.py
test_02_restore_vm_with_disk_offering Error 57.20 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 55.13 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 61.64 test_vm_strict_host_tags.py

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

harikrishna-patnala commented Apr 16, 2025

[SF] Trillian test result (tid-12990) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 61276 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10707-t12990-vmware-70u3.zip Smoke tests completed. 134 look OK, 7 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_01_events_resource Error 326.15 test_events_resource.py
test_01_events_resource Error 326.16 test_events_resource.py
test_04_list_domains_level_filter Failure 0.05 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_05_list_volumes_isrecursive Failure 0.05 test_list_volumes.py
test_07_list_volumes_listall Failure 0.04 test_list_volumes.py
test_04_deploy_vm_for_other_user_and_test_vm_operations Error 122.82 test_network_permissions.py
test_01_deployVMInSharedNetwork Error 169.10 test_network.py
test_02_restore_vm_with_disk_offering Error 57.20 test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size Error 55.13 test_restore_vm.py
test_02_restore_vm_strict_tags_failure Error 61.64 test_vm_strict_host_tags.py

I saw these test failures on other PRs as well, not all but they are failing significant times. We may need to stabilise the base branch.

kiranchavala
kiranchavala approved these changes Apr 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Deploy a VM on CloudStack
  • Stop the VM
  • Via the vCenter, remove the VM from the inventory - leaving behind the VM's disk
  • Attempt Volume migration, this operation failed and CS reports the same error.

Screenshot 2025-04-16 at 1 42 56 PM

@DaanHoogland DaanHoogland merged commit a09354d into apache:4.20 Apr 16, 2025
24 of 25 checks passed
@DaanHoogland DaanHoogland deleted the FixVolumeFailureResponse branch April 16, 2025 08:58
@harikrishna-patnala harikrishna-patnala mentioned this pull request Apr 16, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@harikrishna-patnala @dhslove
Fix volume migration failure response (apache#10707)
1a28b65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

@kiranchavala kiranchavala

Labels

component:storage component:vmware

Projects

None yet

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

Vmware: Volume migration of a VM removed from inventory on vCenter is reported as success even though it fails

4 participants

@harikrishna-patnala @DaanHoogland @blueorangutan @kiranchavala