ui: fix considerlasthost for start vm by shwstppr · Pull Request #10602 · apache/cloudstack

shwstppr · 2025-03-21T11:30:06Z

Description

Fixes #10601

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#10601 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-03-21T11:30:54Z

@blueorangutan ui

blueorangutan · 2025-03-21T11:32:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

bernardodemarco · 2025-03-21T11:34:34Z

ui/src/views/compute/StartVirtualMachine.vue

        }
        for (const key in values) {
-          if (values[key]) {
+          if (values[key] || values[key] === false) {


Couldn't we simply remove this if condition? I don't see how a form's field value could be null or undefined here

@bernardodemarco It may be there because some fields may have an empty value which we shouldn't pass to the API

Okay. Specifically in this form, in which all fields are select components (except for the considerlasthost), the UI does not allow the values to be empty.

However, I think that's a great idea to keep the if statement how you proposed, since that we could, in the future, add more fields to the form that can accept empty/nullable values

codecov · 2025-03-21T11:38:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.16%. Comparing base (95c2481) to head (6252610).
Report is 7 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10602   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11326    11328    +2     
=========================================
  Files          5414     5414           
  Lines        474804   474811    +7     
  Branches      57909    57911    +2     
=========================================
+ Hits          72002    72016   +14     
+ Misses       394749   394743    -6     
+ Partials       8053     8052    -1

Flag	Coverage Δ
uitests	`4.28% <ø> (ø)`
unittests	`15.89% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-03-21T11:48:50Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10602 (QA-JID-579)

bernardodemarco

@shwstppr, I think that we should also tackle this bug when starting VMs through group actions.

I debugged the current behavior of the AutogenView component. On this block of code:

cloudstack/ui/src/views/AutogenView.vue

Lines 1443 to 1447 in 6c40a7b

    
                     const paramsList = this.currentAction.groupMap(this.selectedRowKeys, values, this.items) 
        
                     for (const params of paramsList) { 
        
                       var resourceName = itemsNameMap[params.id] 
        
                       // Using a method for this since it's an async call and don't want wrong prarms to be passed 
        
                       this.promises.push(this.callGroupApi(params, resourceName))

The paramsList variable contains the considerlasthost parameter as undefined and, thus, it is not sent within the API request. To handle that, we could, in the following groupMap field:

cloudstack/ui/src/config/section/compute.js

Lines 116 to 124 in 6c40a7b

    
           api: 'startVirtualMachine', 
        
           icon: 'caret-right-outlined', 
        
           label: 'label.action.start.instance', 
        
           message: 'message.action.start.instance', 
        
           docHelp: 'adminguide/virtual_machines.html#stopping-and-starting-vms', 
        
           dataView: true, 
        
           groupAction: true, 
        
           popup: true, 
        
           groupMap: (selection, values) => { return selection.map(x => { return { id: x, considerlasthost: values.considerlasthost } }) },

Check whether values.considerlasthost is undefined. If so, the considerlasthost field could be set as false.

Edit: The bug when starting VMs through group actions occurs when the form is opened, and the considerlasthost field is not changed. If the field is set to true and switched back to false, then the UI sets the considerlasthost parameter correctly to false.

weizhouapache

code lgtm

makes sense to pass the value "false" to API

weizhouapache · 2025-03-21T12:36:44Z

@shwstppr, I think that we should also tackle this bug when starting VMs through group actions.

I debugged the current behavior of the AutogenView component. On this block of code:

cloudstack/ui/src/views/AutogenView.vue

Lines 1443 to 1447 in 6c40a7b

const paramsList = this.currentAction.groupMap(this.selectedRowKeys, values, this.items)

for (const params of paramsList) {

var resourceName = itemsNameMap[params.id]

// Using a method for this since it's an async call and don't want wrong prarms to be passed

this.promises.push(this.callGroupApi(params, resourceName))

The paramsList variable contains the considerlasthost parameter as undefined and, thus, it is not sent within the API request. To handle that, we could, in the following groupMap field:

cloudstack/ui/src/config/section/compute.js

Lines 116 to 124 in 6c40a7b

api: 'startVirtualMachine',

icon: 'caret-right-outlined',

label: 'label.action.start.instance',

message: 'message.action.start.instance',

docHelp: 'adminguide/virtual_machines.html#stopping-and-starting-vms',

dataView: true,

groupAction: true,

popup: true,

groupMap: (selection, values) => { return selection.map(x => { return { id: x, considerlasthost: values.considerlasthost } }) },

Check whether values.considerlasthost is undefined. If so, the considerlasthost field could be set as false.

Edit: The bug when starting VMs through group actions occurs when the form is opened, and the considerlasthost field is not changed. If the field is set to true and switched back to false, then the UI sets the considerlasthost parameter correctly to false.

good point.
this is indeed a bug

shwstppr · 2025-03-21T16:05:40Z

Thanks guys for group action pointers. Will check and update.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-03-24T05:22:18Z

@blueorangutan ui

blueorangutan · 2025-03-24T05:23:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-03-24T05:39:28Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10602 (QA-JID-582)

DaanHoogland

tested with devtools in qa , parameter is passed

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

ui: fix considerlasthost for start vm

8fe8e99

Fixes apache#10601 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added the component:UI label Mar 21, 2025

shwstppr linked an issue Mar 21, 2025 that may be closed by this pull request

UI: Consider Last Host is ignored #10601

Closed

bernardodemarco reviewed Mar 21, 2025

View reviewed changes

weizhouapache approved these changes Mar 21, 2025

View reviewed changes

fix for group action

6252610

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr marked this pull request as ready for review March 24, 2025 05:57

DaanHoogland added this to the 4.19.3 milestone Mar 24, 2025

DaanHoogland approved these changes Mar 24, 2025

View reviewed changes

DaanHoogland merged commit c1ff799 into apache:4.19 Mar 24, 2025
26 checks passed

DaanHoogland deleted the fix-ui-considerlasthost branch March 24, 2025 11:32

Pearl1594 added this to ACS 4.20.1 Mar 25, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 25, 2025

Pearl1594 mentioned this pull request Mar 25, 2025

UI: Consider Last Host is ignored #10601

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

ui: fix considerlasthost for start vm (apache#10602)

357bb06

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

	const paramsList = this.currentAction.groupMap(this.selectedRowKeys, values, this.items)
	for (const params of paramsList) {
	var resourceName = itemsNameMap[params.id]
	// Using a method for this since it's an async call and don't want wrong prarms to be passed
	this.promises.push(this.callGroupApi(params, resourceName))

	api: 'startVirtualMachine',
	icon: 'caret-right-outlined',
	label: 'label.action.start.instance',
	message: 'message.action.start.instance',
	docHelp: 'adminguide/virtual_machines.html#stopping-and-starting-vms',
	dataView: true,
	groupAction: true,
	popup: true,
	groupMap: (selection, values) => { return selection.map(x => { return { id: x, considerlasthost: values.considerlasthost } }) },

Conversation

shwstppr commented Mar 21, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Mar 21, 2025

Uh oh!

blueorangutan commented Mar 21, 2025

Uh oh!

bernardodemarco Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

bernardodemarco Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 21, 2025

Uh oh!

bernardodemarco left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Mar 21, 2025

Uh oh!

shwstppr commented Mar 21, 2025

Uh oh!

shwstppr commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

blueorangutan commented Mar 24, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Mar 21, 2025 •

edited

Loading

bernardodemarco left a comment •

edited

Loading