Skip to content

StorPool added device ID tag to the StorPool volumes#10587

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
storpool:device-id-tag
Jun 11, 2025
Merged

StorPool added device ID tag to the StorPool volumes#10587
DaanHoogland merged 1 commit intoapache:mainfrom
storpool:device-id-tag

Conversation

@slavkap
Copy link
Copy Markdown
Contributor

@slavkap slavkap commented Mar 19, 2025

Description

This PR adds the device ID as a tag to the attached StorPool volumes. It is needed for the StorPool DR service

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

manual and smoke tests

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 16.30%. Comparing base (9dceae4) to head (ee2bfbb).
Report is 219 commits behind head on main.

Files with missing lines Patch % Lines
...tastore/driver/StorPoolPrimaryDataStoreDriver.java 0.00% 18 Missing ⚠️
...loudstack/storage/datastore/util/StorPoolUtil.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10587      +/-   ##
============================================
- Coverage     16.30%   16.30%   -0.01%     
+ Complexity    13440    13438       -2     
============================================
  Files          5674     5674              
  Lines        499213   499219       +6     
  Branches      60367    60369       +2     
============================================
- Hits          81383    81377       -6     
- Misses       408759   408771      +12     
  Partials       9071     9071
Flag Coverage Δ
uitests 3.99% <ø> (ø)
unittests 17.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pearl1594 Pearl1594 added this to the 4.21.0 milestone Mar 19, 2025
DaanHoogland
DaanHoogland approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

JoaoJandre
JoaoJandre approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoaoJandre JoaoJandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM, but I'm unable to test it

@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 5, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 5, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13613

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jun 9, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 9, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 10, 2025

[SF] Trillian test result (tid-13480)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10587-t13480-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 5c0346e into apache:main Jun 11, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jun 11, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@slavkap @dhslove
Adding device ID to a StorPool volume (apache#10587)
6e42320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

Assignees

No one assigned

Labels

3rd-party:storpool component:integration-test component:primary-storage component:storage has-3rdparty-components Python Warning... Python code Ahead! status:waiting-for-smoketest-results

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

6 participants

@slavkap @sureshanaparti @blueorangutan @DaanHoogland @JoaoJandre @Pearl1594