Skip to content

List only VMs associated to a userdata#10569

Merged
Pearl1594 merged 2 commits into4.19from
fix-list-vm-with-userdata
Mar 17, 2025
Merged

List only VMs associated to a userdata#10569
Pearl1594 merged 2 commits into4.19from
fix-list-vm-with-userdata

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Mar 13, 2025

Description

This PR fixes issue brought up here: #10549 (comment)
Where currently it's not possible to list all VMs associated to a user data.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before fix:
image

Incorrect as the userdata is only associated with 1 VM. The userdata parameter of the listVMs API is to control whether or not to return the userdata as part of the listVms response

After fix:
image

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 requested a review from JoaoJandre March 13, 2025 21:18
@Pearl1594 Pearl1594 added this to the 4.20.1 milestone Mar 13, 2025
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 13, 2025

@blueorangutan package

@Pearl1594 Pearl1594 requested a review from vishesh92 March 13, 2025 21:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (95c2481) to head (692a80b).
Report is 2 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 5 Missing ⚠️
...che/cloudstack/api/command/user/vm/ListVMsCmd.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10569   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11326    11328    +2     
=========================================
  Files          5414     5414           
  Lines        474804   474867   +63     
  Branches      57909    57930   +21     
=========================================
+ Hits          72002    72019   +17     
- Misses       394749   394794   +45     
- Partials       8053     8054    +1
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@bernardodemarco bernardodemarco self-requested a review March 14, 2025 15:04
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 14, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12784

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 14, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2025

[SF] Trillian test result (tid-12702)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10569-t12702-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@Pearl1594 Pearl1594 requested a review from shwstppr March 17, 2025 17:39
shwstppr
shwstppr approved these changes Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 17, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12811

@Pearl1594 Pearl1594 merged commit 02d0dca into 4.19 Mar 17, 2025
48 of 50 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Mar 17, 2025
@Pearl1594 Pearl1594 deleted the fix-list-vm-with-userdata branch March 17, 2025 21:15
phsm pushed a commit to phsm/cloudstack that referenced this pull request Mar 20, 2025
@Pearl1594 @phsm
List only VMs associated to a userdata (apache#10569)
44a8c91 
* List only VMs associated to a userdata

* add since param
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@Pearl1594 @dhslove
List only VMs associated to a userdata (apache#10569)
488811f 
* List only VMs associated to a userdata

* add since param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@JoaoJandre JoaoJandre JoaoJandre approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@vishesh92 vishesh92 Awaiting requested review from vishesh92

@bernardodemarco bernardodemarco Awaiting requested review from bernardodemarco

Assignees

No one assigned

Labels

component:api component:UI

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@Pearl1594 @blueorangutan @shwstppr @DaanHoogland @JoaoJandre