Skip to content

Update ubuntu image link for template download#10559

Merged
Pearl1594 merged 1 commit into4.20from
fix-failing-test
Mar 19, 2025
Merged

Update ubuntu image link for template download#10559
Pearl1594 merged 1 commit into4.20from
fix-failing-test

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Mar 13, 2025 •
edited
Loading

Description

This PR fixes: #10541
Test seems to fail due to :
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels Mar 13, 2025
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 13, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.60%. Comparing base (f8adedc) to head (eb71fb6).
Report is 6 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10559      +/-   ##
============================================
+ Coverage     16.00%   16.60%   +0.60%     
- Complexity    13104    13765     +661     
============================================
  Files          5651     5687      +36     
  Lines        495843   516634   +20791     
  Branches      60045    67080    +7035     
============================================
+ Hits          79363    85800    +6437     
- Misses       407624   421390   +13766     
- Partials       8856     9444     +588
Flag Coverage Δ
uitests 4.14% <ø> (+0.14%) ⬆️
unittests 17.46% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12759

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 13, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland
DaanHoogland approved these changes Mar 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland requested a review from vishesh92 March 13, 2025 13:21
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

[SF] Trillian test result (tid-12670)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56958 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10559-t12670-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1519.90 test_network.py

@Pearl1594 Pearl1594 marked this pull request as draft March 13, 2025 20:15
@Pearl1594 Pearl1594 changed the base branch from main to 4.20 March 13, 2025 20:19
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 13, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 13, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12775

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Mar 14, 2025

@Pearl1594 , should this go into 4.19 as well?

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 14, 2025

May probably have to. @DaanHoogland

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 14, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 15, 2025

[SF] Trillian test result (tid-12693)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56705 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10559-t12693-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1519.85 test_network.py

@Pearl1594 Pearl1594 mentioned this pull request Mar 17, 2025
Merged
@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 17, 2025

Test continued to fail as trillian wasn't updated

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 17, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 17, 2025

[SF] Trillian Build Failed (tid-12737)

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 18, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

[SF] Trillian Build Failed (tid-12742)

@yadvr yadvr added this to the 4.20.1 milestone Mar 18, 2025
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 18, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

[SF] Trillian Build Failed (tid-12744)

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Mar 18, 2025

@blueorangutan test

@Pearl1594 Pearl1594 marked this pull request as ready for review March 18, 2025 12:08
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 18, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 19, 2025

[SF] Trillian test result (tid-12751)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10559-t12751-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@Pearl1594 Pearl1594 merged commit 653b973 into 4.20 Mar 19, 2025
48 of 49 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Mar 19, 2025
@Pearl1594 Pearl1594 deleted the fix-failing-test branch March 19, 2025 12:33
@Pearl1594 Pearl1594 mentioned this pull request Mar 19, 2025
Closed
phsm pushed a commit to phsm/cloudstack that referenced this pull request Mar 20, 2025
@Pearl1594 @phsm
Update ubuntu image link for template download (apache#10559)
2d2fc9a
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@Pearl1594 @dhslove
Update ubuntu image link for template download (apache#10559)
d2fe8fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:marvin Python Warning... Python code Ahead!

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

[test consistently fails](https://github.com/apache/cloudstack/pull/10006#issuecomment-2708058674)

5 participants

@Pearl1594 @blueorangutan @DaanHoogland @yadvr @vishesh92