Skip to content

framework-config: improve configkey caching#10513

Merged
yadvr merged 1 commit intoapache:4.20from
shapeblue:improve-configkey-cache-4.20
Mar 21, 2025
Merged

framework-config: improve configkey caching#10513
yadvr merged 1 commit intoapache:4.20from
shapeblue:improve-configkey-cache-4.20

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Mar 6, 2025

Description

Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
framework-config: improve configkey caching
04be165 
Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (35a7438) to head (04be165).
Report is 16 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10513      +/-   ##
============================================
- Coverage     16.00%   16.00%   -0.01%     
+ Complexity    13103    13101       -2     
============================================
  Files          5651     5651              
  Lines        495841   495836       -5     
  Branches      60044    60044              
============================================
- Hits          79370    79355      -15     
- Misses       407608   407621      +13     
+ Partials       8863     8860       -3
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti
sureshanaparti approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Mar 6, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 6, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12676

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Mar 6, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 6, 2025

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 7, 2025

[SF] Trillian test result (tid-12591)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57423 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10513-t12591-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1520.12 test_network.py

@yadvr yadvr added this to the 4.20.1 milestone Mar 7, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@yadvr yadvr marked this pull request as ready for review March 19, 2025 09:12
vladimirpetrov
vladimirpetrov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on basic smoke testing. There's no way to test global settings with dashes (we don't have any of those) without additional coding so this part was not tested.

@yadvr yadvr merged commit 8df1161 into apache:4.20 Mar 21, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 Mar 21, 2025
@yadvr yadvr deleted the improve-configkey-cache-4.20 branch March 21, 2025 15:57
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@shwstppr @dhslove
framework-config: improve configkey caching (apache#10513)
7cbcdd7 
Using a simple hyphen as a delimiter for config cache key can lead to ambiguity if the “name” field itself contains hyphens. To address this, a Ternary object of configkey name, scope and scope ID is used as the config cache keys.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@abh1sar abh1sar abh1sar approved these changes

Assignees

@vladimirpetrov vladimirpetrov

Labels

None yet

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

7 participants

@shwstppr @sureshanaparti @blueorangutan @yadvr @vladimirpetrov @abh1sar @Pearl1594