Skip to content

lint: fix test_linstor_volumes.py#10502

Merged
Pearl1594 merged 1 commit intoapache:4.20from
shapeblue:fix-testlinstor-lint
Mar 5, 2025
Merged

lint: fix test_linstor_volumes.py#10502
Pearl1594 merged 1 commit intoapache:4.20from
shapeblue:fix-testlinstor-lint

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Mar 5, 2025

Description

Fix lint error in the file - test/integration/plugins/linstor/test_linstor_volumes.py

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fix lint error in the file - test/integration/plugins/linstor/test_linstor_volumes.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Mar 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (80b5d5c) to head (949e797).
Report is 2 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10502   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
- Complexity    13104    13105    +1     
=========================================
  Files          5651     5651           
  Lines        495862   495862           
  Branches      60043    60043           
=========================================
  Hits          79367    79367           
  Misses       407635   407635           
  Partials       8860     8860           
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@bernardodemarco bernardodemarco added this to the 4.20.1 milestone Mar 5, 2025
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can be merged without running tests.

@Pearl1594 Pearl1594 merged commit cdf19b5 into apache:4.20 Mar 5, 2025
25 checks passed
@Pearl1594 Pearl1594 deleted the fix-testlinstor-lint branch March 5, 2025 13:49
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Fix lint error in the file - test/integration/plugins/linstor/test_linstor_volumes.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants