Skip to content

ui: do not cache config.json and locale files#10497

Merged
yadvr merged 1 commit intoapache:4.20from
shapeblue:locale-ts
Mar 5, 2025
Merged

ui: do not cache config.json and locale files#10497
yadvr merged 1 commit intoapache:4.20from
shapeblue:locale-ts

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Mar 4, 2025 •
edited
Loading

This will add a randomised timestamp when fetching config.json and locale i18n files, to avoid using cached json resources. This will address cases when the UI has newer json files (pkgs upgraded/updated).

Fixes #9985

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Testing

Tested by checking UI devtools:

Screenshot 2025-03-04 at 3 58 30 PM

@yadvr
ui: do not cache config.json and locale files
6d568d8 
This will add a randomised timestamp when fetching config.json and
locale i18n files, to avoid using cached resources.

Fixes apache#9985

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.20.1 milestone Mar 4, 2025
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 4, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 4, 2025

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr yadvr linked an issue Mar 4, 2025 that may be closed by this pull request
Post upgrade UI locale cached in web browser #9985
Closed
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Mar 4, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 4, 2025

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.98%. Comparing base (b92fd17) to head (6d568d8).
Report is 12 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #10497      +/-   ##
============================================
- Coverage     15.98%   15.98%   -0.01%     
- Complexity    13086    13087       +1     
============================================
  Files          5650     5650              
  Lines        495756   495756              
  Branches      60018    60018              
============================================
- Hits          79261    79259       -2     
- Misses       407641   407642       +1     
- Partials       8854     8855       +1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.82% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 4, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10497 (QA-JID-569)

shwstppr
shwstppr approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 4, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12652

Pearl1594
Pearl1594 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Mar 4, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12652

11:35:05 + git clone https://github.com/shapeblue/cloudstack-nonoss.git NONOSS --depth=1
11:35:05 Cloning into 'NONOSS'...
11:35:32 error: RPC failed; curl 18 transfer closed with outstanding read data remaining

I don't think we need to try and build this pure ui change further.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Mar 4, 2025

btw qa ui is available and I clicked around a bit without problems (could be considered testing)

@yadvr yadvr merged commit 80b5d5c into apache:4.20 Mar 5, 2025
25 checks passed
@yadvr yadvr deleted the locale-ts branch March 5, 2025 01:39
@yadvr yadvr mentioned this pull request Mar 5, 2025
Closed
@Pearl1594 Pearl1594 mentioned this pull request Mar 5, 2025
Closed
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@yadvr @dhslove
ui: do not cache config.json and locale files (apache#10497)
f2db8bd 
This will add a randomised timestamp when fetching config.json and
locale i18n files, to avoid using cached resources.

Fixes apache#9985

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:UI

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

Post upgrade UI locale cached in web browser

5 participants

@yadvr @blueorangutan @DaanHoogland @shwstppr @Pearl1594