Skip to content

Fix volume allocation logs#10475

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
scclouds:fix-logs-for-volume-allocation
Jun 14, 2025
Merged

Fix volume allocation logs#10475
DaanHoogland merged 1 commit intoapache:mainfrom
scclouds:fix-logs-for-volume-allocation

Conversation

@julien-vaz
Copy link
Copy Markdown
Contributor

@julien-vaz julien-vaz commented Feb 26, 2025

Description

The logs in storage allocation algorithms were displaying incorrect information about the allocation pool. Therefore, the logs were rewritten.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

When trying to migrate a volume, the expected log messages were displayed correctly.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 16.58%. Comparing base (41b4f0a) to head (f2df574).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
...ge/allocator/ClusterScopeStoragePoolAllocator.java 0.00% 1 Missing ⚠️
...torage/allocator/ZoneWideStoragePoolAllocator.java 0.00% 1 Missing ⚠️
.../storage/allocator/RandomStoragePoolAllocator.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #10475   +/-   ##
=========================================
  Coverage     16.57%   16.58%           
  Complexity    13870    13870           
=========================================
  Files          5719     5719           
  Lines        507200   507200           
  Branches      61574    61574           
=========================================
+ Hits          84093    84096    +3     
+ Misses       413688   413685    -3     
  Partials       9419     9419
Flag Coverage Δ
uitests 3.96% <ø> (ø)
unittests 17.45% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julien-vaz
Copy link
Copy Markdown
Contributor Author

julien-vaz commented Mar 5, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 5, 2025

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12667

bernardodemarco
bernardodemarco approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 8, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 8, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 9, 2025

[SF] Trillian test result (tid-12903)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 126964 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10475-t12903-kvm-ol8.zip
Smoke tests completed. 114 look OK, 27 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_browser_migrate_template Error 65.77 test_image_store_object_migration.py
test_01_add_delete_kubernetes_supported_version Error 1801.93 test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup Error 1519.62 test_network.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup Error 0.00 test_password_server.py
ContextSuite context=TestPortForwardingRules>:setup Error 0.00 test_portforwardingrules.py
ContextSuite context=TestProjectSuspendActivate>:setup Error 1529.28 test_projects.py
test_06_purge_expunged_vm_background_task Failure 408.56 test_purge_expunged_vms.py
test_CRUD_operations_userdata Error 1522.30 test_register_userdata.py
test_deploy_vm_with_registered_userdata Error 7.89 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow Error 7.29 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append Error 7.11 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny Error 7.86 test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params Error 7.35 test_register_userdata.py
test_link_and_unlink_userdata_to_template Error 7.49 test_register_userdata.py
test_user_userdata_crud Error 7.66 test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
test_06_download_detached_volume Error 305.49 test_volumes.py
test_13_migrate_volume_and_change_offering Error 126.49 test_volumes.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup Error 0.00 test_resource_accounting.py
ContextSuite context=TestRestoreVM>:setup Error 0.00 test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup Error 0.00 test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup Error 0.00 test_router_dns.py
test_04_nonsecured_to_secured_vm_migration Error 150.57 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 7.01 test_vm_life_cycle.py
ContextSuite context=TestVPCRedundancy>:setup Error 0.00 test_vpc_redundant.py
ContextSuite context=TestVMSchedule>:setup Error 0.00 test_vm_schedule.py
ContextSuite context=TestVmSnapshot>:setup Error 7.34 test_vm_snapshots.py
ContextSuite context=TestMigrateVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestRestoreVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestScaleVMStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup Error 0.00 test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance Error 312.02 test_vnf_templates.py
ContextSuite context=TestIpv6Vpc>:setup Error 0.00 test_vpc_ipv6.py
ContextSuite context=TestVPCNics>:setup Error 0.00 test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 0.00 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 0.00 test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs Error 1.63 test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure Error 1.74 test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected Failure 18.65 test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected Failure 21.73 test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected Failure 29.32 test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown Error 30.51 test_host_maintenance.py
test_disable_oobm_ha_state_ineligible Error 1517.87 test_hostha_kvm.py

lucas-a-martins
lucas-a-martins approved these changes Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 19, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@JoaoJandre
Copy link
Copy Markdown
Contributor

JoaoJandre commented Jun 2, 2025

@julien-vaz could you fix the conflicts?

@julien-vaz
Copy link
Copy Markdown
Contributor Author

julien-vaz commented Jun 4, 2025

@julien-vaz could you fix the conflicts?

Sure!

Improves StoragePoolAllocators' logs
f2df574 
Applies sugested changes
@julien-vaz julien-vaz force-pushed the fix-logs-for-volume-allocation branch from 34ad14b to f2df574 Compare June 4, 2025 21:45
@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jun 5, 2025

@blueorangutan package

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 5, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 5, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13616

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 9, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13667

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 11, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13723

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 12, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13741

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jun 13, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 13, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 14, 2025

[SF] Trillian test result (tid-13514)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59131 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10475-t13514-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit e83a347 into apache:main Jun 14, 2025
22 of 26 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@julien-vaz @dhslove
Improves StoragePoolAllocators' logs (apache#10475)
f3b3cf0 
Co-authored-by: Julien Hervot de Mattos Vaz <julien.vaz@scclouds.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

+1 more reviewer

@lucas-a-martins lucas-a-martins lucas-a-martins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:storage

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

7 participants

@julien-vaz @blueorangutan @DaanHoogland @JoaoJandre @sureshanaparti @lucas-a-martins @bernardodemarco