Remove isMirrored parameter when creating a disk offering through UI#10474
Merged
DaanHoogland merged 1 commit intoapache:4.20from Mar 4, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10474 +/- ##
============================================
+ Coverage 15.98% 16.16% +0.17%
- Complexity 13086 13276 +190
============================================
Files 5650 5667 +17
Lines 495756 498095 +2339
Branches 60018 60264 +246
============================================
+ Hits 79261 80493 +1232
- Misses 407641 408586 +945
- Partials 8854 9016 +162
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JoaoJandre
approved these changes
Feb 28, 2025
Contributor
|
@julien-vaz Does this effect 4.20 as well, if so can you rebase the code to 4.20 please. Thanks. |
…iskOffering API through UI
52bf2ec to
cb851bc
Compare
Contributor
Author
|
@julien-vaz a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Contributor
|
verified in QA after: |
|
Awesome work, congrats on your first merged pull request! |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
…iskOffering API through UI (apache#10474) Co-authored-by: Julien Hervot de Mattos Vaz <julien.vaz@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a Disk Offering is created through UI, CloudStack passes the
isMirroredvalue as a parameter. However, thecreateDiskOfferingAPI does not have this parameter.Therefore, the UI was changed in order to not send the
isMirroredparameter to thecreateDiskOfferingAPI.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
After the changes, a Disk Offering was created through UI and the
isMirroredparameter was no longer being send in the request.