Skip to content

cloudstack-setup-databases: fix mode and group of key file#10466

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-key-file
Feb 28, 2025
Merged

cloudstack-setup-databases: fix mode and group of key file#10466
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-key-file

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Feb 26, 2025

Description

This PR fixes the mode and group of key file, which should have same setting as db.properties file

see issue below:

# ls -l /etc/cloudstack/management/key /etc/cloudstack/management/db.properties 
-rw-r-----. 1 root cloud 4802 Feb  8 13:50 /etc/cloudstack/management/db.properties
-rw-r--r--. 1 root root     8 Feb  8 13:50 /etc/cloudstack/management/key

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Feb 26, 2025

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (a09c579) to head (0e6a8eb).
Report is 3 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10466   +/-   ##
=========================================
  Coverage     15.15%   15.15%           
  Complexity    11315    11315           
=========================================
  Files          5413     5413           
  Lines        474709   474709           
  Branches      57894    57894           
=========================================
  Hits          71940    71940           
  Misses       394723   394723           
  Partials       8046     8046
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland
DaanHoogland approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 26, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12578

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Feb 26, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 26, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 27, 2025

[SF] Trillian test result (tid-12499)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46601 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10466-t12499-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache marked this pull request as ready for review February 27, 2025 11:12
@yadvr yadvr added this to the 4.20.1 milestone Feb 28, 2025
@yadvr yadvr merged commit f50de89 into apache:4.19 Feb 28, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-key-file branch February 28, 2025 06:35
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
cloudstack-setup-databases: fix mode and group of key file (apache#10466
ebe7029 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @DaanHoogland @blueorangutan @yadvr @Pearl1594