Skip to content

systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1#10462

Merged
yadvr merged 1 commit intoapache:4.20from
shapeblue:systemvmtemplate-bump4201
Feb 28, 2025
Merged

systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1#10462
yadvr merged 1 commit intoapache:4.20from
shapeblue:systemvmtemplate-bump4201

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Feb 25, 2025

This bumps the version of the base OS ISO to Debian 12.9.0 and use ACS version identifier to be 4.20.1 (next release).

Also fixes the build failures (iso links 404).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

@yadvr
systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1
80a128c 
This bumps the version of the base OS ISO to Debian 12.9.0 and use
ACS version identifier to be 4.20.1 (next release).

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>
@yadvr yadvr added this to the 4.20.1 milestone Feb 25, 2025
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Feb 25, 2025

I've kicked multi-arch builds which will be available here in 2-3 hrs (the arm64 builds on x86 machine are slow): https://build.yadav.cloud/systemvm/

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.99%. Comparing base (e8ac477) to head (80a128c).
Report is 10 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10462   +/-   ##
=========================================
  Coverage     15.99%   15.99%           
  Complexity    13086    13086           
=========================================
  Files          5649     5649           
  Lines        495710   495710           
  Branches      60013    60013           
=========================================
+ Hits          79286    79288    +2     
+ Misses       407574   407572    -2     
  Partials       8850     8850
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

weizhouapache
weizhouapache approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

DaanHoogland
DaanHoogland approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, some practical questions
Should we use these builds to upload to downloads.cloudstack.org?
And will you honour us with testing the arm versions?

Pearl1594
Pearl1594 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Feb 28, 2025

@DaanHoogland

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Feb 28, 2025 •
edited
Loading

I'll merge this based on the builds, for actual testing, these templates can be used. For now, the scope of the PR was to ensure builds work with the corrected ISO urls.

Around mid-march I'm happy to do new sets of builds and move them to download.cloudstack.org server and update root & engine/schema pom.xml with the systemvmtemplate version. cc @Pearl1594 @DaanHoogland

@yadvr yadvr merged commit 2d00933 into apache:4.20 Feb 28, 2025
25 checks passed
@yadvr yadvr deleted the systemvmtemplate-bump4201 branch February 28, 2025 04:35
@Pearl1594 Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@yadvr @dhslove
systemvmtemplate: bump version Debian 12.9.0 and ACS 4.20.1 (apache#1…
7aa1315 
…0462)

This bumps the version of the base OS ISO to Debian 12.9.0 and use
ACS version identifier to be 4.20.1 (next release).

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:templates systemvm-template-change

Projects

ACS 4.20.1
Status: Done

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @DaanHoogland @Pearl1594 @weizhouapache