Skip to content

VMware import - logs sanitation#10433

Merged
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:vmware-import-logs-sanitation
May 16, 2025
Merged

VMware import - logs sanitation#10433
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:vmware-import-logs-sanitation

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Feb 20, 2025 •
edited
Loading

Description

This PR sanitises logs of ovftool cmd during vmware import.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested, and checked the logs.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.19.2 milestone Feb 20, 2025
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Feb 20, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 20, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (1f8442e) to head (51af846).
Report is 15 commits behind head on 4.19.

Files with missing lines Patch % Lines
...s/src/main/java/com/cloud/utils/script/Script.java 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10433      +/-   ##
============================================
- Coverage     15.17%   15.16%   -0.01%     
+ Complexity    11340    11336       -4     
============================================
  Files          5414     5414              
  Lines        475093   475084       -9     
  Branches      57971    57970       -1     
============================================
- Hits          72086    72069      -17     
- Misses       394945   394956      +11     
+ Partials       8062     8059       -3
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiranchavala
Copy link
Copy Markdown
Member

kiranchavala commented Feb 20, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 20, 2025

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Feb 20, 2025

@blueorangutan package

@apache apache deleted a comment from blueorangutan Feb 20, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 20, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 20, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12522

@sureshanaparti sureshanaparti removed this from the 4.19.2 milestone Feb 20, 2025
@DaanHoogland DaanHoogland added this to the 4.19.3 milestone Feb 20, 2025
@Pearl1594 Pearl1594 moved this to In Progress in ACS 4.20.1 Mar 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 24, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti sureshanaparti force-pushed the vmware-import-logs-sanitation branch from efc7b08 to 51af846 Compare May 5, 2025 07:47
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented May 5, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 5, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13258

DaanHoogland
DaanHoogland approved these changes May 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti marked this pull request as ready for review May 8, 2025 16:53
@sureshanaparti sureshanaparti requested a review from NuxRo May 8, 2025 16:56
@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 9, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2025

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13308

kiranchavala
kiranchavala approved these changes May 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Before fix

Cloudstack was logging the vcenter credentials

2025-05-15 12:34:05,970 DEBUG [resource.wrapper.LibvirtConvertInstanceCommandWrapper] (agentRequest-Handler-1:[]) (logid:edec8444) Executing command [ovftool --noSSLVerify vi://administrator%40vsphere.local:P%40ssword123@10.0.35.100/Trillian/vm/e552b5c2-f4d3-4c15-93a1-6a2c560df142 /mnt/a1047887-9e10-3157-9336-432b0b47ecfe/01a1d8ab-e41f-4fc6-a288-aac8b787a100/ ].

After fix

2025-05-15 11:54:53,033 DEBUG [resource.wrapper.LibvirtConvertInstanceCommandWrapper] (agentRequest-Handler-4:null) (logid:0fa4514f) Executing command [ovftool --noSSLVerify vi://******@10.0.35.100/Trillian/vm/5cbc76b0-feaf-40ab-ac0d-4abb09b72885 /mnt/f30da0ff-56c0-364d-9146-caa63d6d3de0/0c73a2e1-4113-423b-8359-958d41635464/ ]

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 15, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 15, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 16, 2025

[SF] Trillian test result (tid-13323)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46545 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10433-t13323-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit f199783 into apache:4.19 May 16, 2025
25 of 26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ACS 4.20.1 May 16, 2025
@DaanHoogland DaanHoogland deleted the vmware-import-logs-sanitation branch May 16, 2025 07:21
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@sureshanaparti @dhslove
VMware import - logs sanitation (apache#10433)
48b5216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@NuxRo NuxRo Awaiting requested review from NuxRo

Assignees

@kiranchavala kiranchavala

@NuxRo NuxRo

Labels

component:kvm component:vmware

Projects

ACS 4.20.1
Status: Done

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

7 participants

@sureshanaparti @blueorangutan @kiranchavala @yadvr @DaanHoogland @NuxRo @Pearl1594