Skip to content

UI: Fix Apache CloudStack description on the onboarding page#10373

Merged
DaanHoogland merged 17 commits intoapache:4.19from
bernardodemarco:fix-onboarding-message
Feb 17, 2025
Merged

UI: Fix Apache CloudStack description on the onboarding page#10373
DaanHoogland merged 17 commits intoapache:4.19from
bernardodemarco:fix-onboarding-message

Conversation

@bernardodemarco
Copy link
Copy Markdown
Member

Description

Currently, the Apache CloudStack description on the onboarding page states that:

Both open-source and Premium versions are available, with the open-source version offering nearly identical features

This PR removes this outdated sentence.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

@bernardodemarco bernardodemarco added this to the 4.19.3 milestone Feb 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.15%. Comparing base (ae1d7cc) to head (1ba7d33).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10373      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
  Complexity    11314    11314              
============================================
  Files          5413     5413              
  Lines        474670   474670              
  Branches      57890    57890              
============================================
- Hits          71943    71937       -6     
- Misses       394680   394687       +7     
+ Partials       8047     8046       -1     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@DaanHoogland
Copy link
Copy Markdown
Contributor

Though I have no objection to the change, I wonder if premium versions are really still available. As far as I know the current developing companies contributeeverything they add to the open source version, so the premium bit would not make sense.

@bernardodemarco
Copy link
Copy Markdown
Member Author

@DaanHoogland yes, and IMHO, even if there were premium versions that don't push upstream, it would not be our responsibility, as an Apache project, to inform users about these premium versions.

@DaanHoogland
Copy link
Copy Markdown
Contributor

Ok, so as the release candidate for 4.19.2 is already out I propose to merge this as soon as it is voted on. for now it has no high priority.

@DaanHoogland
Copy link
Copy Markdown
Contributor

the RC is stopped with an issue. I think we can risk this one before the next RC

@DaanHoogland DaanHoogland merged commit 7bef256 into apache:4.19 Feb 17, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
…10373)

* remove sentence from en.json

* remove sentence from ar.json

* remove sentence from ca.json

* remove sentence from de_DE.json

* remove sentence from el_GR.json

* remove sentence from es.json

* remove sentence from fr_FR.json

* remove sentence from hu.json

* remove sentence from it_IT.json

* remove sentence from ko_KR.json

* remove sentence from nb_NO.json

* remove sentence from ja_JP.json

* remove sentence from nl_NL.json

* remove sentence from pl.json

* remove sentence from pt_BR.json

* remove sentence from ru_RU.json

* remove sentence from zh_CN.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants