Skip to content

UI: Add change host password#10337

Merged
Pearl1594 merged 2 commits intoapache:4.20from
scclouds:change-password-UI
Mar 3, 2025
Merged

UI: Add change host password#10337
Pearl1594 merged 2 commits intoapache:4.20from
scclouds:change-password-UI

Conversation

@lucas-a-martins
Copy link
Copy Markdown
Contributor

@lucas-a-martins lucas-a-martins commented Feb 6, 2025

Description

Currently is possible to change the host's password by using the updateHostPassword API; however, this option is not available in the UI.

This PR adds the option to change the host's password via UI.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Screenshot from 2025-02-05 18-10-50

How Has This Been Tested?

In a local environment, I checked that the new option was available and tried to change the password using the new form. Looking the database I verified that the password changed.

I also forced some exceptions, like by using a wrong username as a parameter. Everything worked as expected.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (2ef1613) to head (5ce9fa4).
Report is 35 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10337      +/-   ##
============================================
+ Coverage     16.02%   16.15%   +0.13%     
- Complexity    13146    13264     +118     
============================================
  Files          5658     5667       +9     
  Lines        496312   497989    +1677     
  Branches      60109    60243     +134     
============================================
+ Hits          79537    80468     +931     
- Misses       407926   408512     +586     
- Partials       8849     9009     +160
Flag Coverage Δ
uitests 4.00% <ø> (-0.02%) ⬇️
unittests 17.00% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 6, 2025

@blueorangutan ui

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Feb 6, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 6, 2025

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 6, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10337 (QA-JID-543)

bernardodemarco
bernardodemarco approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested in a local environment.

Verified that the UI validates if the values inserted in the New password and Confirm password fields are equal. If they're not, then the message Please enter the same value again. is returned. Also verified that the API parameters are correctly specified when executing the updateHostPassword API.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 19, 2025

@lucas-a-martins , is this applicanble to 4.20 as well?

@lucas-a-martins
Copy link
Copy Markdown
Contributor Author

lucas-a-martins commented Feb 19, 2025

@lucas-a-martins , is this applicanble to 4.20 as well?

It is. Do you want me to rebase it and change the target branch? :)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 20, 2025

@lucas-a-martins , is this applicanble to 4.20 as well?

It is. Do you want me to rebase it and change the target branch? :)

please lets not keep a good fix from people longer then needed.

Lucas Martins and others added 2 commits February 20, 2025 12:33
Add updateHostPassword API to UI
651ca38
@lucas-a-martins @bernardodemarco
remove unnecessary check
c5a8b0b 
Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 20, 2025

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@lucas-a-martins lucas-a-martins changed the base branch from main to 4.20 February 20, 2025 15:42
DaanHoogland
DaanHoogland approved these changes Feb 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 28, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 28, 2025

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 28, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10337 (QA-JID-562)

@Pearl1594 Pearl1594 merged commit b92fd17 into apache:4.20 Mar 3, 2025
@lucas-a-martins lucas-a-martins deleted the change-password-UI branch March 3, 2025 18:14
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@lucas-a-martins @bernardodemarco @dhslove
UI: Add change host password (apache#10337)
d6c1f75 
* Add updateHostPassword API to UI

* remove unnecessary check

Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>

---------

Co-authored-by: Lucas Martins <lucas.martins@scclouds.com.br>
Co-authored-by: Bernardo De Marco Gonçalves <bernardomg2004@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

component:UI type:improvement

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

7 participants

@lucas-a-martins @DaanHoogland @blueorangutan @yadvr @bernardodemarco @Pearl1594 @sureshanaparti