Skip to content

changed the kubernetestool url#10295

Merged
DaanHoogland merged 1 commit intoapache:4.19from
kiranchavala:changing-kubernetes-url-419
Jan 30, 2025
Merged

changed the kubernetestool url#10295
DaanHoogland merged 1 commit intoapache:4.19from
kiranchavala:changing-kubernetes-url-419

Conversation

@kiranchavala
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala commented Jan 29, 2025

Description

Currently, if we execute the script (create-kubernetes-binaries-iso.sh) to create the latest CKS iso its fails with the following error

+ mkdir -p /tmp/iso//docker
++ /tmp/iso//k8s/kubeadm config images list --kubernetes-version=v1.31.1
/tmp/iso//k8s/kubeadm: line 1: syntax error near unexpected token `<'
/tmp/iso//k8s/kubeadm: line 1: `<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubernetes-release/release/v1.31.1/bin/linux/amd64/kubeadm</Details></Error>'

On investigating found that kubernetes community recommended to use "dl.k8s.io" instead of "storage.googleapis.com/kubernetes-release"

Blog post

https://kubernetes.io/blog/2023/06/09/dl-adopt-cdn/

CircleCI-Public/kubernetes-orb#74

kubernetes/kubernetes#127796

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

After making the change the cks iso got created successfully

+ curl -L --remote-name-all https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubeadm https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubelet https://dl.k8s.io//release/v1.31.1/bin/linux/amd64/kubectl
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138  100   138    0     0    383      0 --:--:-- --:--:-- --:--:--   383
100 55.5M  100 55.5M    0     0  18.2M      0  0:00:03  0:00:03 --:--:-- 22.3M
100   138  100   138    0     0    985      0 --:--:-- --:--:-- --:--:--   985
100 73.3M  100 73.3M    0     0  21.7M      0  0:00:03  0:00:03 --:--:-- 23.1M
100   138  100   138    0     0    985      0 --:--:-- --:--:-- --:--:--   985
100 53.7M  100 53.7M    0     0  5296k      0  0:00:10  0:00:10 --:--:-- 5070k
++ stat --format %a kubeadm

DaanHoogland
DaanHoogland approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (f652ad0) to head (a24ffa5).
Report is 12 commits behind head on 4.19.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10295   +/-   ##
=========================================
  Coverage     15.14%   15.14%           
- Complexity    11282    11283    +1     
=========================================
  Files          5408     5408           
  Lines        473823   473823           
  Branches      57826    57826           
=========================================
+ Hits          71763    71772    +9     
+ Misses       394038   394026   -12     
- Partials       8022     8025    +3
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 29, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Jan 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12251

DaanHoogland
DaanHoogland approved these changes Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested the url out of bounds and works

@DaanHoogland DaanHoogland merged commit 641a606 into apache:4.19 Jan 30, 2025
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
@kiranchavala
changed the kubernetestool url (apache#10295)
745f884
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@kiranchavala @dhslove
changed the kubernetestool url (apache#10295)
bb6f5fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

5 participants

@kiranchavala @DaanHoogland @blueorangutan @Pearl1594 @weizhouapache