ui: fix column filter for templates, isos#10288
Merged
DaanHoogland merged 1 commit intoapache:4.19from Jan 31, 2025
Merged
Conversation
Template and ISO list was showing State column as undefined in the column filter. This PR fixes such cases when the column key is an object. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10288 +/- ##
============================================
+ Coverage 15.13% 15.14% +0.01%
- Complexity 11274 11282 +8
============================================
Files 5408 5408
Lines 473974 473823 -151
Branches 57813 57826 +13
============================================
+ Hits 71730 71762 +32
+ Misses 394227 394038 -189
- Partials 8017 8023 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Jan 28, 2025
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks good, verified in qa
bernardodemarco
approved these changes
Jan 28, 2025
Member
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, tested in the QA environment:
-
Before
-
After
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jun 19, 2025
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Template and ISO list was showing State column as undefined in the column filter. This PR fixes such cases when the column key is an object.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?