Skip to content

Fix NPE during account creation#10274

Merged
DaanHoogland merged 1 commit intoapache:4.19from
bernardodemarco:npe-when-creating-account
Jan 30, 2025
Merged

Fix NPE during account creation#10274
DaanHoogland merged 1 commit intoapache:4.19from
bernardodemarco:npe-when-creating-account

Conversation

@bernardodemarco
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco commented Jan 25, 2025

Description

During account creation, if the log level of the com.cloud category is set to TRACE, a NPE is thrown, making it impossible to create accounts. This PR fixes this NPE.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before applying the changes, setting the log level of the com.cloud category to TRACE caused account creation to fail due to a NPE.

After applying the changes, the NPE is no longer thrown, and accounts can be created without any issues.

@bernardodemarco bernardodemarco added this to the 4.19.2 milestone Jan 25, 2025
@bernardodemarco
Copy link
Copy Markdown
Member Author

bernardodemarco commented Jan 25, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2025

@bernardodemarco a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.14%. Comparing base (0a77eb7) to head (f496ff1).
Report is 10 commits behind head on 4.19.

Files with missing lines Patch % Lines
...c/main/java/com/cloud/user/AccountManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10274      +/-   ##
============================================
- Coverage     15.14%   15.14%   -0.01%     
+ Complexity    11283    11280       -3     
============================================
  Files          5408     5408              
  Lines        473823   473822       -1     
  Branches      57824    57824              
============================================
- Hits          71764    71756       -8     
- Misses       394037   394044       +7     
  Partials       8022     8022
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 25, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12209

DaanHoogland
DaanHoogland approved these changes Jan 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 27, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 27, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Jan 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@borisstoyanov borisstoyanov self-assigned this Jan 27, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 27, 2025

[SF] Trillian test result (tid-12191)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 43237 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10274-t12191-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could not reproduce the NPE

@DaanHoogland DaanHoogland merged commit c70e4e2 into apache:4.19 Jan 30, 2025
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
@bernardodemarco
fix npe on account creation (apache#10274)
e872a86
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@bernardodemarco @dhslove
fix npe on account creation (apache#10274)
58b8d58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

@borisstoyanov borisstoyanov

Labels

status:ready-for-merge

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

5 participants

@bernardodemarco @blueorangutan @DaanHoogland @sureshanaparti @borisstoyanov