Skip to content

Fix NPE while checking for user data provider#10255

Merged
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:edge-vr-destroy-npe-issue
Feb 4, 2025
Merged

Fix NPE while checking for user data provider#10255
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:edge-vr-destroy-npe-issue

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Jan 23, 2025 •
edited
Loading

Description

This PR fixes NPE issues while checking for user data provider.

Fixes #9847

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti linked an issue Jan 23, 2025 that may be closed by this pull request
Delete edge vr showing internal server error. #9847
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (0d5047b) to head (69d45d0).
Report is 4 commits behind head on 4.19.

Files with missing lines Patch % Lines
...oud/network/element/ConfigDriveNetworkElement.java 0.00% 11 Missing and 2 partials ⚠️
...om/cloud/network/element/VirtualRouterElement.java 0.00% 5 Missing ⚠️
.../main/java/com/cloud/network/NetworkModelImpl.java 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10255   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11300    11303    +3     
=========================================
  Files          5408     5408           
  Lines        473912   473929   +17     
  Branches      57844    57851    +7     
=========================================
+ Hits          71855    71871   +16     
+ Misses       394025   394023    -2     
- Partials       8032     8035    +3
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.88% <4.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti sureshanaparti mentioned this pull request Jan 23, 2025
Closed
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Jan 23, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 23, 2025
DaanHoogland
DaanHoogland approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12189

@apache apache deleted a comment from blueorangutan Jan 23, 2025
@apache apache deleted a comment from blueorangutan Jan 23, 2025
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Jan 24, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 24, 2025

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 24, 2025

[SF] Trillian test result (tid-12181)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10255-t12181-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@sureshanaparti sureshanaparti marked this pull request as ready for review January 29, 2025 10:04
Pearl1594
Pearl1594 reviewed Jan 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just one comment.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 31, 2025

@sureshanaparti , the issue speaks of deletion of a VR in an edge zone. Are there special requirements for testing this fix concerning making an edge zone?
tnx

@sureshanaparti sureshanaparti force-pushed the edge-vr-destroy-npe-issue branch from c941c6e to 69d45d0 Compare February 3, 2025 10:13
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Feb 3, 2025 •
edited
Loading

@sureshanaparti , the issue speaks of deletion of a VR in an edge zone. Are there special requirements for testing this fix concerning making an edge zone? tnx

@DaanHoogland create edge zone and don't register direct download systemvm template. Create shared network and try to deploy VM (The network creation fails as there is no direct download systemvm template to create the VR, at this point - destroy the VR of the shared network).

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Feb 3, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 3, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 3, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12307

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 3, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 3, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Pearl1594
Pearl1594 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sureshanaparti. LGTM. Code has been made more defensive to prevent NPEs.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 4, 2025

[SF] Trillian test result (tid-12279)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50199 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10255-t12279-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_12_start_vm_multiple_volumes_allocated Error 15.11 test_vm_life_cycle.py

@DaanHoogland DaanHoogland merged commit 238d0c5 into apache:4.19 Feb 4, 2025
@DaanHoogland DaanHoogland deleted the edge-vr-destroy-npe-issue branch February 4, 2025 08:59
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@sureshanaparti @dhslove
Fix NPE while checking for user data provider (apache#10255)
80f5994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

@Pearl1594 Pearl1594

Labels

component:networking

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

Delete edge vr showing internal server error.

4 participants

@sureshanaparti @blueorangutan @DaanHoogland @Pearl1594