UI: Fix domain view when opening details for a specific domainid#10245
UI: Fix domain view when opening details for a specific domainid#10245DaanHoogland merged 2 commits intoapache:4.19from
Conversation
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10245 +/- ##
=========================================
Coverage 15.14% 15.14%
- Complexity 11281 11283 +2
=========================================
Files 5408 5408
Lines 473767 473818 +51
Branches 57812 57823 +11
=========================================
+ Hits 71752 71764 +12
- Misses 393992 394032 +40
+ Partials 8023 8022 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
tested in qa with and without change.
bc6c4fc to
b59105e
Compare
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@vishesh92 I can see that domain page is fixed when a domain is clicked but when I click back button I'm seeing this 404 error. Can you please check it.
|
I think I know why this is happening. Let me fix that. |
|
@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Description
This PR fixes #9893
Details
This pull request includes updates to the
DomainView.vuecomponent to improve data fetching and rendering logic. The most important changes include adding a condition to thetree-viewcomponent and modifying the data fetching mechanism to watch for route parameter changes.Improvements to data fetching and rendering:
ui/src/views/iam/DomainView.vue: Added av-elsecondition to thetree-viewcomponent to ensure it only renders when appropriate.ui/src/views/iam/DomainView.vue: Changed thecreatedlifecycle hook to watch for changes in the route parameters and fetch data immediately when the component is created.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?