Skip to content

server: apply network ACL even if there is no network ACLs in the ACL list (#9374)#10241

Merged
DaanHoogland merged 1 commit intoapache:4.20from
weizhouapache:4.20-port-pr9374
May 1, 2025
Merged

server: apply network ACL even if there is no network ACLs in the ACL list (#9374)#10241
DaanHoogland merged 1 commit intoapache:4.20from
weizhouapache:4.20-port-pr9374

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jan 22, 2025

Description

This PR re-applies #9374

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 22, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 22, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.13%. Comparing base (96b757c) to head (a1daf60).
Report is 199 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10241   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
  Complexity    12972    12972           
=========================================
  Files          5639     5639           
  Lines        494297   494294    -3     
  Branches      59908    59908           
=========================================
+ Hits          79773    79775    +2     
+ Misses       405698   405694    -4     
+ Partials       8826     8825    -1
Flag Coverage Δ
uitests 4.02% <ø> (ø)
unittests 16.98% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, probably a merge error

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 22, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12172

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 22, 2025

@blueorangutan test

@weizhouapache weizhouapache marked this pull request as ready for review January 22, 2025 17:02
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 22, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

[SF] Trillian test result (tid-12171)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 40614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10241-t12171-kvm-ol8.zip
Smoke tests completed. 131 look OK, 1 have errors, 9 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.28 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.38 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.38 test_ipv4_routing.py
all_test_volumes Skipped --- test_volumes.py
all_test_vpc_ipv6 Skipped --- test_vpc_ipv6.py
all_test_vpc_redundant Skipped --- test_vpc_redundant.py
all_test_vpc_router_nics Skipped --- test_vpc_router_nics.py
all_test_vpc_vpn Skipped --- test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py
all_test_hostha_kvm Skipped --- test_hostha_kvm.py

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 23, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

[SF] Trillian Build Failed (tid-12173)

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 28, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 28, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 29, 2025

[SF] Trillian test result (tid-12211)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54129 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10241-t12211-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_11_isolated_network_with_dynamic_routed_mode Error 2.34 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.46 test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode Error 3.47 test_ipv4_routing.py

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Mar 18, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12820

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Mar 18, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 18, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 19, 2025

[SF] Trillian test result (tid-12749)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57760 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10241-t12749-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Mar 19, 2025
@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 1, 2025

Is this good to merge or some manual QA is required @weizhouapache @DaanHoogland ?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 1, 2025

extra testing never hurts, but I think this was due to a merge forward.

@DaanHoogland DaanHoogland merged commit fe77f5f into apache:4.20 May 1, 2025
@DaanHoogland DaanHoogland deleted the 4.20-port-pr9374 branch May 1, 2025 07:25
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
server: apply network ACL even if there is no network ACLs in the ACL…
4941d6e 
… list (apache#9374) (apache#10241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:networking

Projects

None yet

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @yadvr @DaanHoogland