Skip to content

server: fix scale vm with same disk offering id#10235

Merged
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-9776-scale-vm
Feb 9, 2025
Merged

server: fix scale vm with same disk offering id#10235
DaanHoogland merged 1 commit intoapache:4.19from
weizhouapache:4.19-fix-9776-scale-vm

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jan 22, 2025 •
edited
Loading

Description

This PR fixes #9776 (comment)

steps to reproduce the issue

  • create disk offering
  • create service offering 1/2 with same disk offering and strictness=true
  • create vm with service offering 1
  • stop the vm
  • scale vm with service offering 2

expected result: success
actual result: fail

see #9776 (comment) for the screenshot.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Jan 22, 2025 that may be closed by this pull request
Compute offering is not listed for vm when using disk offering strictness parameter #9776
Closed
@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 22, 2025
DaanHoogland
DaanHoogland approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (a627ab6) to head (96b4e7c).
Report is 6 commits behind head on 4.19.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##              4.19   #10235       +/-   ##
============================================
+ Coverage     4.29%   15.15%   +10.86%     
- Complexity       0    11314    +11314     
============================================
  Files          367     5409     +5042     
  Lines        29620   474664   +445044     
  Branches      5194    57904    +52710     
============================================
+ Hits          1272    71936    +70664     
- Misses       28203   394686   +366483     
- Partials       145     8042     +7897
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@borisstoyanov borisstoyanov self-assigned this Jan 22, 2025
@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Jan 22, 2025

@blueorangutan package

@weizhouapache weizhouapache marked this pull request as ready for review January 22, 2025 13:23
borisstoyanov
borisstoyanov approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually checked user is able to scale to new offering now.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 22, 2025

thanks @borisstoyanov

if there is no smoke test failures, let's merge

@blueorangutan test

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 23, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 23, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Jan 30, 2025
@apache apache deleted a comment from blueorangutan Jan 30, 2025
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jan 31, 2025

@blueorangutan test

@borisstoyanov borisstoyanov removed their assignment Feb 4, 2025
@DaanHoogland DaanHoogland force-pushed the 4.19-fix-9776-scale-vm branch from 0aeeabf to 96b4e7c Compare February 7, 2025 12:14
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@apache apache deleted a comment from blueorangutan Feb 7, 2025
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 7, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12377

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Feb 7, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 8, 2025

[SF] Trillian test result (tid-12341)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48882 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10235-t12341-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_10_attachAndDetach_iso Error 12.60 test_vm_life_cycle.py

@DaanHoogland DaanHoogland merged commit d920aba into apache:4.19 Feb 9, 2025
@DaanHoogland DaanHoogland deleted the 4.19-fix-9776-scale-vm branch February 9, 2025 08:35
@DaanHoogland DaanHoogland mentioned this pull request Feb 9, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
server: fix scale vm with same disk offering id (apache#10235)
d63a816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

Assignees

No one assigned

Labels

status:waiting-for-smoketest-results

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

Compute offering is not listed for vm when using disk offering strictness parameter

4 participants

@weizhouapache @borisstoyanov @blueorangutan @DaanHoogland