Skip to content

Support virtio-blk root disk controller#10229

Merged
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:fix-virtio-blk-419
Feb 10, 2025
Merged

Support virtio-blk root disk controller#10229
DaanHoogland merged 2 commits intoapache:4.19from
shapeblue:fix-virtio-blk-419

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Jan 21, 2025

Description

This PR adds support for virtio-blk devices
Fixes: #9299

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Jan 21, 2025

@blueorangutan package

@nvazquez nvazquez mentioned this pull request Jan 21, 2025
Closed
@nvazquez nvazquez linked an issue Jan 21, 2025 that may be closed by this pull request
Virtio-blk support fstrim #9299
Closed
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 21, 2025

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jan 21, 2025

do we need to update

cloudstack/server/src/main/java/com/cloud/api/query/QueryManagerImpl.java

Line 5065 in 81e052c

options.put(VmDetailConstants.ROOT_DISK_CONTROLLER, Arrays.asList("osdefault", "ide", "scsi", "virtio"));

?

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 21, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 21, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12152

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Jan 21, 2025

Thanks @weizhouapache, fixed

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 21, 2025

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (91f1ada) to head (167a427).
Report is 48 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 3 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 0 Missing and 1 partial ⚠️
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.19   #10229   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11279    11281    +2     
=========================================
  Files          5408     5408           
  Lines        474007   474009    +2     
  Branches      57822    57823    +1     
=========================================
+ Hits          71745    71748    +3     
+ Misses       394241   394238    -3     
- Partials       8021     8023    +2
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 21, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12153

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Jan 22, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 22, 2025

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland
DaanHoogland approved these changes Jan 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 22, 2025

[SF] Trillian test result (tid-12159)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 44051 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10229-t12159-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_list_cpvm_vm Failure 0.05 test_ssvm.py
test_04_cpvm_internals Failure 0.05 test_ssvm.py

@nvazquez nvazquez marked this pull request as ready for review January 23, 2025 02:38
Pearl1594
Pearl1594 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented Feb 10, 2025

tested ok. LGTM

@DaanHoogland DaanHoogland merged commit 4f604c0 into apache:4.19 Feb 10, 2025
@DaanHoogland DaanHoogland deleted the fix-virtio-blk-419 branch February 10, 2025 14:03
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@nvazquez @dhslove
Support virtio-blk root disk controller (apache#10229)
c4a266a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

4.19.2

Development

Successfully merging this pull request may close these issues.

Virtio-blk support fstrim

5 participants

@nvazquez @blueorangutan @weizhouapache @Pearl1594 @DaanHoogland