Skip to content

merge bug fix for #9037; no retrieval of null hosts#10175

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fix-merge-bug-from-9037
Jan 13, 2025
Merged

merge bug fix for #9037; no retrieval of null hosts#10175
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:fix-merge-bug-from-9037

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Jan 10, 2025 •
edited
Loading

Description

This PR fixes a bug introduces when merging forward #9037 from 4.18 to 4.19. Two lines were added where they shouldn't have.
see https://lists.apache.org/thread/ty756jn3vr7vmltr95087g9vjxm8sqbx

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jan 10, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.12%. Comparing base (afc95f1) to head (018d495).
Report is 2 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10175      +/-   ##
============================================
- Coverage     15.12%   15.12%   -0.01%     
+ Complexity    11268    11267       -1     
============================================
  Files          5408     5408              
  Lines        473954   473952       -2     
  Branches      57810    57810              
============================================
- Hits          71709    71707       -2     
  Misses       394231   394231              
  Partials       8014     8014
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 12043

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Jan 10, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 10, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cltgm, verified changes in #9037

@DaanHoogland DaanHoogland marked this pull request as ready for review January 10, 2025 12:12
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jan 11, 2025

[SF] Trillian test result (tid-12086)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47857 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10175-t12086-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit fce7773 into apache:4.19 Jan 13, 2025
@DaanHoogland DaanHoogland deleted the fix-merge-bug-from-9037 branch January 13, 2025 08:28
DaanHoogland added a commit that referenced this pull request Jan 13, 2025
@DaanHoogland
Merge release branch 4.20 to main
bd874ea 
* 4.20:
  systemvm: fix keystore is reset when patch a systemvm (#9900)
  no retrieval of null hosts (#10175)
  upgrade: consider multiple hypervisors and secondary storages (#10046)
  CheckOnHostCommand: add missing timeout setting (#9677)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 16, 2025
@DaanHoogland @dhslove
no retrieval of null hosts (apache#10175)
5a8872e
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
@DaanHoogland
no retrieval of null hosts (apache#10175)
b2082d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @blueorangutan @Pearl1594 @sureshanaparti @weizhouapache