pre-commit add hook `check-shebang-scripts-are-executable` for Shell by jbampton · Pull Request #10150 · apache/cloudstack

jbampton · 2024-12-31T13:26:54Z

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-shebang-scripts-are-executable

Ran chmod +x

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-shebang-scripts-are-executable Ran `chmod +x`

codecov · 2024-12-31T13:34:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.39%. Comparing base (96ccd7e) to head (ab13677).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10150      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
- Complexity    15283    15285       +2     
============================================
  Files          5889     5889              
  Lines        526141   526141              
  Branches      64234    64234              
============================================
- Hits          91542    91541       -1     
  Misses       424265   424265              
- Partials      10334    10335       +1

Flag	Coverage Δ
uitests	`3.62% <ø> (ø)`
unittests	`18.44% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jbampton · 2024-12-31T13:57:32Z

@blueorangutan package

blueorangutan · 2024-12-31T13:58:03Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-31T15:02:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11964

DaanHoogland

looks good, I think it is not needed as the package job/installer takes care of these. I see no objections to these anyway.

DaanHoogland · 2024-12-31T15:30:15Z

@blueorangutan test

blueorangutan · 2024-12-31T15:32:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-01T23:00:07Z

[SF] Trillian test result (tid-12022)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 110826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10150-t12022-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3640.46	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3635.99	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3635.72	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	3634.03	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	3637.90	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	3635.38	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3653.92	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	3692.68	test_kubernetes_clusters.py
test_04_nonsecured_to_secured_vm_migration	`Error`	429.54	test_vm_life_cycle.py

DaanHoogland · 2025-01-02T12:46:45Z

@blueorangutan test

blueorangutan · 2025-01-02T12:48:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-03T20:03:55Z

[SF] Trillian test result (tid-12030)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 110094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10150-t12030-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3627.78	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3642.16	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3641.55	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	3640.39	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	3631.11	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	3642.44	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3663.33	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	3702.98	test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn	`Failure`	469.28	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	327.21	test_vpc_vpn.py

jbampton · 2025-09-16T19:05:16Z

@blueorangutan package

blueorangutan · 2025-09-16T19:06:06Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-09-16T21:02:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15044

DaanHoogland · 2025-09-17T10:37:05Z

@blueorangutan test

blueorangutan · 2025-09-17T10:38:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-09-18T02:01:01Z

[SF] Trillian test result (tid-14369)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52081 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10150-t14369-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	1.14	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	34.97	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	486.03	test_kubernetes_clusters.py

…pache#10150)

pre-commit add hook check-shebang-scripts-are-executable for Shell

46e8e50

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-shebang-scripts-are-executable Ran `chmod +x`

boring-cyborg bot added component:networking component:templates component:virtual-router component:XenServer systemvm-template-change labels Dec 31, 2024

DaanHoogland approved these changes Dec 31, 2024

View reviewed changes

vishesh92 approved these changes Jan 3, 2025

View reviewed changes

jbampton and others added 2 commits September 17, 2025 03:36

Merge branch 'main' into check-shebang-scripts-are-executable-shell

91b7440

Fix shell script file permissions

ab13677

DaanHoogland approved these changes Sep 17, 2025

View reviewed changes

DaanHoogland merged commit 33cfede into apache:main Sep 17, 2025
26 checks passed

jbampton deleted the check-shebang-scripts-are-executable-shell branch September 17, 2025 19:44

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

pre-commit add hook check-shebang-scripts-are-executable for Shell (a…

2cda9a1

…pache#10150)

Conversation

jbampton commented Dec 31, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jbampton commented Dec 31, 2024

Uh oh!

blueorangutan commented Dec 31, 2024

Uh oh!

blueorangutan commented Dec 31, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 31, 2024

Uh oh!

blueorangutan commented Dec 31, 2024

Uh oh!

blueorangutan commented Jan 1, 2025

Uh oh!

DaanHoogland commented Jan 2, 2025

Uh oh!

blueorangutan commented Jan 2, 2025

Uh oh!

blueorangutan commented Jan 3, 2025

Uh oh!

jbampton commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

blueorangutan commented Sep 16, 2025

Uh oh!

DaanHoogland commented Sep 17, 2025

Uh oh!

blueorangutan commented Sep 17, 2025

Uh oh!

Uh oh!

blueorangutan commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 31, 2024 •

edited

Loading