Removal of UI blockage to access the `changeOfferingForVolume` API by LayonRibeiro · Pull Request #10135 · apache/cloudstack

LayonRibeiro · 2024-12-23T12:42:36Z

Description

This PR corrects an incorrect behavior in the UI where users who have access to the changeOfferingForVolume API, but are not admins, cannot use it.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Before

After

How Has This Been Tested?

A role was created (based on the default user role) with permission to access the changeOfferingForVolume API.
An account and a user were created using this role.
The changeOfferingForVolume API icon appeared correctly in the UI (npm run server).
The change in the volume offer was made correctly

ui/src/config/section/storage.js

shwstppr · 2024-12-26T05:17:37Z

@blueorangutan ui

blueorangutan · 2024-12-26T05:18:04Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov · 2024-12-26T05:25:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.30%. Comparing base (0934fb1) to head (376bd4f).
⚠️ Report is 574 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10135      +/-   ##
============================================
- Coverage     16.30%   16.30%   -0.01%     
+ Complexity    13450    13447       -3     
============================================
  Files          5675     5675              
  Lines        499249   499249              
  Branches      60377    60377              
============================================
- Hits          81425    81420       -5     
- Misses       408753   408757       +4     
- Partials       9071     9072       +1

Flag	Coverage Δ
uitests	`3.99% <ø> (ø)`
unittests	`17.16% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2024-12-26T05:34:59Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-504)

ui/src/config/section/storage.js

Co-authored-by: dahn <daan.hoogland@gmail.com>

ui/src/config/section/storage.js

sureshanaparti · 2025-06-05T09:40:04Z

@blueorangutan ui

blueorangutan · 2025-06-05T09:41:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-06-05T09:59:31Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10135 (QA-JID-638)

DaanHoogland

clgtm

RosiKyu · 2025-08-17T07:53:14Z

@blueorangutan package

blueorangutan · 2025-08-17T07:54:04Z

@rosi-shapeblue a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-17T09:04:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14654

RosiKyu

Verification passed. Working as expected.

Tested with a non-admin user assigned to a custom role allowing changeOfferingForVolume. The “Change Offering” icon is now visible in the UI, and the offering change works as expected.

NOTE: Minor UI i18n issue: message.change.offering.for.volume.processing key is shown instead of a user-friendly message.

Screencast.from.2025-10-12.17-01-11.webm

LGTM.

DaanHoogland · 2025-10-13T08:06:40Z

@shwstppr @weizhouapache , are you gouys alright with this to merge now?

weizhouapache

code lgtm

apache#10135)

Show icon to changeOfferingForVolume for the other users

13078a7

boring-cyborg bot added the component:UI label Dec 23, 2024

LayonRibeiro changed the title ~~Show icon to changeOfferingForVolume for the other users~~ Removal of UI blockage to access the changeOfferingForVolume API Dec 23, 2024

shwstppr reviewed Dec 26, 2024

View reviewed changes

ui/src/config/section/storage.js Outdated Show resolved Hide resolved

DaanHoogland reviewed Dec 27, 2024

View reviewed changes

ui/src/config/section/storage.js Outdated Show resolved Hide resolved

LayonRibeiro and others added 2 commits December 27, 2024 14:42

Update ui/src/config/section/storage.js

517f8a1

Co-authored-by: dahn <daan.hoogland@gmail.com>

Removed admin role verification

b8b2163

shwstppr reviewed Jan 16, 2025

View reviewed changes

ui/src/config/section/storage.js Outdated Show resolved Hide resolved

check update

cd511c0

LayonRibeiro force-pushed the PR-Remove-UI-Blockage-on-Change-Volume-Offering branch from 2e274bf to cd511c0 Compare January 31, 2025 15:26

Merge branch 'main' into PR-Remove-UI-Blockage-on-Change-Volume-Offering

376bd4f

DaanHoogland added this to the 4.21.0 milestone Apr 3, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

DaanHoogland approved these changes Jun 9, 2025

View reviewed changes

RosiKyu self-assigned this Aug 17, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

RosiKyu approved these changes Oct 12, 2025

View reviewed changes

shwstppr approved these changes Oct 13, 2025

View reviewed changes

weizhouapache approved these changes Oct 13, 2025

View reviewed changes

weizhouapache merged commit 136ea3e into apache:main Oct 13, 2025
26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 13, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025

UI: Removal of UI blockage to access the changeOfferingForVolume API (

72e1e1e

apache#10135)

Conversation

LayonRibeiro commented Dec 23, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

shwstppr commented Dec 26, 2024

Uh oh!

blueorangutan commented Dec 26, 2024

Uh oh!

codecov bot commented Dec 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Dec 26, 2024

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

RosiKyu commented Aug 17, 2025

Uh oh!

blueorangutan commented Aug 17, 2025

Uh oh!

blueorangutan commented Aug 17, 2025

Uh oh!

RosiKyu left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 13, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Dec 26, 2024 •

edited

Loading