Remove SNI option in _run.sh, as it is correct as default. by DaanHoogland · Pull Request #10028 · apache/cloudstack

DaanHoogland · 2024-12-03T10:48:37Z

Description

This PR...

Fixes: #9962

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2024-12-03T10:52:52Z

@DaanHoogland
target to 4.19/4.20 or main ?

codecov · 2024-12-03T10:54:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.13%. Comparing base (47f6019) to head (0bfaef3).
Report is 1 commits behind head on 4.19.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10028   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11261    11263    +2     
=========================================
  Files          5408     5408           
  Lines        473842   473842           
  Branches      57771    57771           
=========================================
+ Hits          71696    71697    +1     
  Misses       394145   394145           
+ Partials       8001     8000    -1

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.85% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-03T11:40:07Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache

code lgtm

DaanHoogland · 2024-12-03T14:49:41Z

@blueorangutan package

blueorangutan · 2024-12-03T14:52:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-03T15:49:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11695

DaanHoogland · 2024-12-04T06:50:11Z

@blueorangutan test

blueorangutan · 2024-12-04T06:52:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-04T21:59:14Z

[SF] Trillian test result (tid-11840)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10028-t11840-kvm-ol8.zip
Smoke tests completed. 129 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.05	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.05	test_ssvm.py
test_01_secure_vm_migration	`Error`	134.41	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.41	test_vm_life_cycle.py
test_06_download_detached_volume	`Failure`	436.36	test_volumes.py
test_01_redundant_vpc_site2site_vpn	`Failure`	421.60	test_vpc_vpn.py

DaanHoogland · 2024-12-05T08:35:20Z

[SF] Trillian test result (tid-11840) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52094 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10028-t11840-kvm-ol8.zip Smoke tests completed. 129 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_02_list_cpvm_vm Failure 0.05 test_ssvm.py
test_04_cpvm_internals Failure 0.05 test_ssvm.py
test_01_secure_vm_migration Error 134.41 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.41 test_vm_life_cycle.py
test_06_download_detached_volume Failure 436.36 test_volumes.py
test_01_redundant_vpc_site2site_vpn Failure 421.60 test_vpc_vpn.py

some of these errors seem completely unrelated and some might be, re-running for comparison

DaanHoogland · 2024-12-05T08:35:47Z

@blueorangutan package

blueorangutan · 2024-12-05T08:38:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2024-12-05T09:31:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

blueorangutan · 2024-12-05T09:57:16Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11720

DaanHoogland · 2024-12-05T10:16:07Z

@blueorangutan test

blueorangutan · 2024-12-05T10:18:07Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-05T23:34:22Z

[SF] Trillian test result (tid-11854)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45381 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10028-t11854-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	133.29	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	133.29	test_vm_life_cycle.py

DaanHoogland · 2024-12-06T08:55:45Z

test_01_secure_vm_migration fails as "Unable to deploy the VM as the host: ol8.localdomain is not in the right state" is consistent, however I am not sure if it is related as I have seen this error in other PRs as well ... needs investigation.

weizhouapache · 2024-12-06T09:50:57Z

test_01_secure_vm_migration fails as "Unable to deploy the VM as the host: ol8.localdomain is not in the right state" is consistent, however I am not sure if it is related as I have seen this error in other PRs as well ... needs investigation.

@DaanHoogland
seems unrelated.

I recall we have faced the issue before

2024-12-05 19:22:41,560 DEBUG [c.c.h.Status] (AgentConnectTaskPool-13:ctx-1c122273) (logid:0523be08) Unable to update host for event:Ready. Name=ol8.localdomain; New=[status=Up:msid=null:lastpinged=1692799264]; Old=[status=Connecting:msid=null:lastpinged=1692799264]; DB=[status=Connecting:msid=32987513095075:lastpinged=1692799259:old update count=45]
2024-12-05 19:22:41,561 INFO  [c.c.u.e.CSExceptionErrorCode] (AgentConnectTaskPool-15:ctx-b814e2d3) (logid:b85f4adb) Could not find exception: com.cloud.exception.ConnectionException in error code list for exceptions
2024-12-05 19:22:41,561 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentTaskPool-9:ctx-d2c55a62) (logid:315eb3a2) Notifying other nodes of to disconnect
2024-12-05 19:22:41,562 DEBUG [c.c.a.m.AgentManagerImpl] (AgentConnectTaskPool-15:ctx-b814e2d3) (logid:b85f4adb) Failed to handle host connection:
com.cloud.exception.ConnectionException: Unable to acquire lock on host 1922ce9f-4d1d-453e-bf1f-4676592379a4
    at com.cloud.agent.manager.AgentManagerImpl.sendReadyAndGetAttache(AgentManagerImpl.java:1155)
    at com.cloud.agent.manager.AgentManagerImpl.handleConnectedAgent(AgentManagerImpl.java:1168)
    at com.cloud.agent.manager.AgentManagerImpl$HandleAgentConnectTask.runInContext(AgentManagerImpl.java:1252)
    at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
    at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)

cc @vishesh92

DaanHoogland · 2024-12-06T12:08:58Z

ok @weizhouapache @vishesh92 do we merge this and create a new issue for this?

test_01_secure_vm_migration fails as "Unable to deploy the VM as the host: ol8.localdomain is not in the right state" is consistent, however I am not sure if it is related as I have seen this error in other PRs as well ... needs investigation.

@DaanHoogland seems unrelated.

I recall we have faced the issue before

2024-12-05 19:22:41,560 DEBUG [c.c.h.Status] (AgentConnectTaskPool-13:ctx-1c122273) (logid:0523be08) Unable to update host for event:Ready. Name=ol8.localdomain; New=[status=Up:msid=null:lastpinged=1692799264]; Old=[status=Connecting:msid=null:lastpinged=1692799264]; DB=[status=Connecting:msid=32987513095075:lastpinged=1692799259:old update count=45]
2024-12-05 19:22:41,561 INFO  [c.c.u.e.CSExceptionErrorCode] (AgentConnectTaskPool-15:ctx-b814e2d3) (logid:b85f4adb) Could not find exception: com.cloud.exception.ConnectionException in error code list for exceptions
2024-12-05 19:22:41,561 DEBUG [c.c.a.m.ClusteredAgentManagerImpl] (AgentTaskPool-9:ctx-d2c55a62) (logid:315eb3a2) Notifying other nodes of to disconnect
2024-12-05 19:22:41,562 DEBUG [c.c.a.m.AgentManagerImpl] (AgentConnectTaskPool-15:ctx-b814e2d3) (logid:b85f4adb) Failed to handle host connection:
com.cloud.exception.ConnectionException: Unable to acquire lock on host 1922ce9f-4d1d-453e-bf1f-4676592379a4
    at com.cloud.agent.manager.AgentManagerImpl.sendReadyAndGetAttache(AgentManagerImpl.java:1155)
    at com.cloud.agent.manager.AgentManagerImpl.handleConnectedAgent(AgentManagerImpl.java:1168)
    at com.cloud.agent.manager.AgentManagerImpl$HandleAgentConnectTask.runInContext(AgentManagerImpl.java:1252)
    at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
    at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
    at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)

cc @vishesh92

weizhouapache · 2024-12-06T13:09:57Z

ok @weizhouapache @vishesh92 do we merge this and create a new issue for this?

I think we can merge

DaanHoogland · 2024-12-06T13:46:54Z

thanks @weizhouapache merged. I will keep an I on the HealthCheck PR for this one.

DaanHoogland linked an issue Dec 3, 2024 that may be closed by this pull request

ssvm: unable to find valid certification path to requested target #9962

Closed

DaanHoogland added the component:systemvm-iso label Dec 3, 2024

DaanHoogland added this to the 4.19.2 milestone Dec 3, 2024

DaanHoogland force-pushed the 9962-ssvm-unable-to-find-valid-certification-path-to-requested-target branch from 97f3b41 to 969205a Compare December 3, 2024 11:39

boring-cyborg bot added component:api component:kvm component:networking component:storage labels Dec 3, 2024

github-actions bot added the status:has-conflicts label Dec 3, 2024

DaanHoogland changed the base branch from main to 4.19 December 3, 2024 11:40

weizhouapache approved these changes Dec 3, 2024

View reviewed changes

github-actions bot removed the status:has-conflicts label Dec 3, 2024

DaanHoogland marked this pull request as ready for review December 3, 2024 14:49

DaanHoogland changed the title ~~Remove SNI option that is correct as default in _run.sh~~ Remove SNI option, as it is correct as default, in _run.sh Dec 4, 2024

DaanHoogland changed the title ~~Remove SNI option, as it is correct as default, in _run.sh~~ Remove SNI option in _run.sh, as it is correct as default. Dec 4, 2024

yadvr approved these changes Dec 4, 2024

View reviewed changes

Remove SNI option that is correct as default in _run.sh

0bfaef3

DaanHoogland force-pushed the 9962-ssvm-unable-to-find-valid-certification-path-to-requested-target branch from 969205a to 0bfaef3 Compare December 5, 2024 08:35

DaanHoogland merged commit 971a5b2 into 4.19 Dec 6, 2024

DaanHoogland deleted the 9962-ssvm-unable-to-find-valid-certification-path-to-requested-target branch December 6, 2024 13:46

DaanHoogland mentioned this pull request Dec 6, 2024

ssvm: unable to find valid certification path to requested target #9962

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024

Remove SNI option that is correct as default in _run.sh (apache#10028)

5cade26

Conversation

DaanHoogland commented Dec 3, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Dec 3, 2024

Uh oh!

codecov bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 3, 2024

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Dec 3, 2024

Uh oh!

blueorangutan commented Dec 3, 2024

Uh oh!

blueorangutan commented Dec 3, 2024

Uh oh!

DaanHoogland commented Dec 4, 2024

Uh oh!

blueorangutan commented Dec 4, 2024

Uh oh!

blueorangutan commented Dec 4, 2024

Uh oh!

DaanHoogland commented Dec 5, 2024

Uh oh!

DaanHoogland commented Dec 5, 2024

Uh oh!

blueorangutan commented Dec 5, 2024

Uh oh!

sonarqubecloud bot commented Dec 5, 2024

Quality Gate passed

Uh oh!

blueorangutan commented Dec 5, 2024

Uh oh!

DaanHoogland commented Dec 5, 2024

Uh oh!

blueorangutan commented Dec 5, 2024

Uh oh!

blueorangutan commented Dec 5, 2024

Uh oh!

DaanHoogland commented Dec 6, 2024

Uh oh!

weizhouapache commented Dec 6, 2024

Uh oh!

DaanHoogland commented Dec 6, 2024

Uh oh!

weizhouapache commented Dec 6, 2024

Uh oh!

DaanHoogland commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 3, 2024 •

edited

Loading