fix: fix race in Uuids.ClockSeqAndNodeContainer double-checked init#2050
Conversation
lukasz-antoniak
left a comment
There was a problem hiding this comment.
Thanks for the patch!
|
Can you just change commit message to |
lukasz-antoniak
left a comment
There was a problem hiding this comment.
Good catch, just please change commit message. I do not think we need a JIRA for such a small change.
c475bf7 to
ca7ed6b
Compare
|
@lukasz-antoniak done! |
|
Just the one-line |
ca7ed6b to
6798e1e
Compare
|
@lukasz-antoniak done done! =) |
|
Good find @jasonk000! I've kicked off a Jenkins run just to confirm that there aren't any unexpected downstream effects from this change but I'm not expecting anything interesting to pop up there. Assuming that's good I think we'll be okay to get this merged! |
|
Jenkins run is clean, I think we're good here. Thanks for the good work @jasonk000! |
patch by Jason Koch; reviewed by Lukasz Antoniak and Bret McGuire reference: apache#2050
6798e1e to
f777d71
Compare
Reordered writes in ClockSeqAndNodeContainer.get() to assign
valbefore setting the volatileinitializedflag.The updated sequence ensures
valis fully constructed and visible before publication via the volatile write.