JAVA-3022 implementation of private link address translator#1597
Conversation
adutra
left a comment
There was a problem hiding this comment.
Thanks for the PR!
If this lands in the driver I'd also like to see reference.conf amended. Please modify the advanced.address-translator section and:
- Mention the new translator there;
- Add the new
advertised-hostnameoption there (it should be commented out by default).
|
@adutra I fixed what I could, thanks for the review. This build will fail anyway on |
adutra
left a comment
There was a problem hiding this comment.
I fixed your build issues, hope you don't mind. I will let @absurdfarce have a look and merge since he's the real boss ™️ now :-)
This test is a special one that verifies that the programmatic configuration API would produce the exact same configuration as the file-based configuration API. Since the option in reference.conf is commented out, it should not appear either in |
|
Hi @adutra , would you mind to fix the build once again? I am not sure what's wrong but "mvn clean install" fails again. I think I just force pushed something by accident and your changes are not there anymore. |
|
Ok it seems I managed to build it. |
JAVA-3022: Implementation of address translator for fixed hostname (apache#1597)
We are open to rename this translator to match more generic use case. See JAVA-3022.