Skip to content

Upgrade Netty to 4.1.93.Final#3975

Merged
eolivelli merged 1 commit into
apache:masterfrom
lhotari:lh-upgrade-netty-4.1.93
May 31, 2023
Merged

Upgrade Netty to 4.1.93.Final#3975
eolivelli merged 1 commit into
apache:masterfrom
lhotari:lh-upgrade-netty-4.1.93

Conversation

@lhotari

@lhotari lhotari commented May 29, 2023

Copy link
Copy Markdown
Member

Changes & Motivation

  • Upgrade Netty to 4.1.93.Final and io_uring transport to 0.0.21.Final
    • includes netty-tcnative 2.0.61.Final

Highlights:

Release notes:

- Upgrade Netty to 4.1.93.Final and io_uring transport to 0.0.21.Final
  - includes netty-tcnative 2.0.61.Final

Highlights:
- Upgrade to latest netty-tcnative to fix memory leak in 4.1.93.Final
  netty/netty#13375
- native SSL implementation fixes in 4.1.91.Final
  https://twitter.com/normanmaurer/status/1642884593522032640
- performance improvements in 4.1.90.Final and 4.1.92.Final
  https://twitter.com/normanmaurer/status/1635671472566837248
  https://twitter.com/normanmaurer/status/1650816576885538816

Release notes:
https://netty.io/news/2023/03/14/4-1-90-Final.html
https://netty.io/news/2023/04/03/4-1-91-Final.html
https://netty.io/news/2023/04/25/4-1-92-Final.html
https://netty.io/news/2023/05/25/4-1-93-Final.html
@hangc0276 hangc0276 added dependencies Pull requests that update a dependency file release/4.16.2 labels May 30, 2023
@hangc0276 hangc0276 added this to the 4.17.0 milestone May 30, 2023
@Ghatage

Ghatage commented May 30, 2023

Copy link
Copy Markdown
Contributor

@lhotari Just wondering, client performance over the network is super sensitive to netty version changes. At least in our experience. I wonder:

  1. Whats your opinion on this?
  2. What does community do to catch perf regressions etc. in such scenarios.

cc @jvrao @reddycharan

@eolivelli

Copy link
Copy Markdown
Contributor

we run performance tests daily/weekly against all the Pulsar and we would find regressions

we usually update Netty in the Pulsar repo and automatically the Bookie and the BK client use the new version and it is pretty easy to see of there is a breaking change

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli eolivelli merged commit f8d81f7 into apache:master May 31, 2023
zymap pushed a commit that referenced this pull request Jun 19, 2023
- Upgrade Netty to 4.1.93.Final and io_uring transport to 0.0.21.Final
  - includes netty-tcnative 2.0.61.Final

Highlights:
- Upgrade to latest netty-tcnative to fix memory leak in 4.1.93.Final
  netty/netty#13375
- native SSL implementation fixes in 4.1.91.Final
  https://twitter.com/normanmaurer/status/1642884593522032640
- performance improvements in 4.1.90.Final and 4.1.92.Final
  https://twitter.com/normanmaurer/status/1635671472566837248
  https://twitter.com/normanmaurer/status/1650816576885538816

Release notes:
https://netty.io/news/2023/03/14/4-1-90-Final.html
https://netty.io/news/2023/04/03/4-1-91-Final.html
https://netty.io/news/2023/04/25/4-1-92-Final.html
https://netty.io/news/2023/05/25/4-1-93-Final.html

(cherry picked from commit f8d81f7)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
- Upgrade Netty to 4.1.93.Final and io_uring transport to 0.0.21.Final
  - includes netty-tcnative 2.0.61.Final

Highlights:
- Upgrade to latest netty-tcnative to fix memory leak in 4.1.93.Final
  netty/netty#13375
- native SSL implementation fixes in 4.1.91.Final
  https://twitter.com/normanmaurer/status/1642884593522032640
- performance improvements in 4.1.90.Final and 4.1.92.Final
  https://twitter.com/normanmaurer/status/1635671472566837248
  https://twitter.com/normanmaurer/status/1650816576885538816

Release notes:
https://netty.io/news/2023/03/14/4-1-90-Final.html
https://netty.io/news/2023/04/03/4-1-91-Final.html
https://netty.io/news/2023/04/25/4-1-92-Final.html
https://netty.io/news/2023/05/25/4-1-93-Final.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/branch-4.16 dependencies Pull requests that update a dependency file release/4.16.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants