AutoRecovery - Do not call shutdown() on the main ZookKeeper client thread #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lhotari
approved these changes
Sep 14, 2022
dlg99
approved these changes
Sep 14, 2022
nicoloboschi
approved these changes
Sep 14, 2022
nicoloboschi
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Sep 16, 2022
…hread (apache#3487) (cherry picked from commit 6fc2e08)
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AutoRecoveryMain.shutdown() performs blocking operations.
We are calling "shutdown" on the main ZookKeeper client thread.
More context in this Pulsar case apache/pulsar#17638
Changes
Run "shutdown" in a separate thread