[BEAM-7038] Revert "[BEAM-3279] Deprecate and remove Coder.consistentWithEquals (#8071)#8258
Merged
aaltay merged 1 commit intoapache:masterfrom Apr 9, 2019
Merged
[BEAM-7038] Revert "[BEAM-3279] Deprecate and remove Coder.consistentWithEquals (#8071)#8258aaltay merged 1 commit intoapache:masterfrom
aaltay merged 1 commit intoapache:masterfrom
Conversation
…pache#8071)" This reverts commit 43db80d.
Member
Author
|
cc: @AlexKbit |
Member
Author
|
R: @boyuanzz |
boyuanzz
approved these changes
Apr 9, 2019
Member
Author
|
Thank you for the quick reviews. I will merge after tests pass. (Please feel free to merge it, if you get a chance before I do.) |
Member
|
Run Java PreCommit |
Member
Author
|
ElasticsearchIOTest tests are failing, I do not believe they are related to this change. Re-running the tests. |
Member
Author
|
Run Java PreCommit |
aaltay
added a commit
to aaltay/beam
that referenced
this pull request
Apr 9, 2019
[BEAM-7038] Revert "[BEAM-3279] Deprecate and remove Coder.consistentWithEquals (apache#8071)
apilloud
added a commit
that referenced
this pull request
Apr 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 43db80d.
#8071 is incomaptible with Dataflow update, details in BEAM-7038
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.