Skip to content

[BEAM-7011] Update Beam SDKs to use the StandardSideInputType enums.#8232

Merged
lukecwik merged 4 commits intoapache:masterfrom
lukecwik:side_input
Apr 8, 2019
Merged

[BEAM-7011] Update Beam SDKs to use the StandardSideInputType enums.#8232
lukecwik merged 4 commits intoapache:masterfrom
lukecwik:side_input

Conversation

@lukecwik
Copy link
Copy Markdown
Member

@lukecwik lukecwik commented Apr 4, 2019

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- --- --- --- ---
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Python Build Status
Build Status		 --- Build Status
Build Status		 Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik lukecwik changed the title [BEAM-7011] Update Beam to use the StandardSideInputType enums. [BEAM-7011] Update Beam SDKs to use the StandardSideInputType enums. Apr 4, 2019
@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 4, 2019

R: @lostluck
CC: @CraigChambersG

@lostluck
Copy link
Copy Markdown
Contributor

lostluck commented Apr 5, 2019

@lukecwik You'll need to clean up the go imports for this change to compile, as Go has strict include what you use semantics.

18:02:25 .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/runners/dataflow/dataflowlib/fixup.go:19:2: imported and not used: "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/graphx"
18:02:25 .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/runners/dataflow/dataflowlib/fixup.go:20:2: imported and not used: "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/pipelinex"
18:02:25 .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/runners/dataflow/dataflowlib/fixup.go:21:2: imported and not used: "github.com/apache/beam/sdks/go/pkg/beam/core/util/protox"
18:02:25 .gogradle/project_gopath/src/github.com/apache/beam/sdks/go/pkg/beam/runners/dataflow/dataflowlib/fixup.go:23:2: imported and not used: "github.com/apache/beam/sdks/go/vendor/github.com/golang/protobuf/proto"

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Thanks Robert

Is there tooling that does this automatically?

@lostluck
Copy link
Copy Markdown
Contributor

lostluck commented Apr 5, 2019

There are, but most IDEs configured for Go should be automatically downloading and using them onsave.
The one that handles imports specifically, is goimports

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

R: @lostluck

@lostluck
Copy link
Copy Markdown
Contributor

lostluck commented Apr 5, 2019

LGTM

@lostluck
Copy link
Copy Markdown
Contributor

lostluck commented Apr 5, 2019

Note: I think the formatting changes in the go code are from go version differences for whomever is running go fmt. I think many of these changed (and I updated in a PR) after I updated my local go to 1.12.
Either way, they're benign if a bit noisy, and not worth nit-ing over.

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Yes, I use go 1.12 locally, didn't know that the fmt had changed.

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Run Python PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Run Java PreCommit

2 similar comments
@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Run Java PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Run Java PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 5, 2019

Run Python PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 8, 2019

Run Java PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 8, 2019

Run Python PreCommit

@lukecwik
Copy link
Copy Markdown
Member Author

lukecwik commented Apr 8, 2019

Run Java PreCommit

@lukecwik lukecwik merged commit 684f813 into apache:master Apr 8, 2019
@lukecwik lukecwik mentioned this pull request Apr 12, 2019
Merged
3 tasks
chamikaramj added a commit to chamikaramj/beam that referenced this pull request Apr 15, 2019
@chamikaramj
Revert "[BEAM-7011] Update Beam SDKs to use the StandardSideInputType…
5517713 
… enums. (apache#8232)"

This reverts commit 684f813.
@chamikaramj chamikaramj mentioned this pull request Apr 15, 2019
Closed
3 tasks
ibzib pushed a commit to ibzib/beam that referenced this pull request Apr 22, 2019
@lukecwik
[BEAM-7011] Update Beam SDKs to use the StandardSideInputType enums. (a…
5f0f933 
…pache#8232)

* [BEAM-7011] Update Beam to use the StandardSideInputType enums.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukecwik @lostluck