[BEAM-5328] Starter Archetype generation fix & correctness test#7715
Merged
lukecwik merged 2 commits intoapache:masterfrom Apr 9, 2019
Merged
[BEAM-5328] Starter Archetype generation fix & correctness test#7715lukecwik merged 2 commits intoapache:masterfrom
lukecwik merged 2 commits intoapache:masterfrom
Conversation
lukecwik
approved these changes
Apr 5, 2019
Member
There was a problem hiding this comment.
To finish BEAM-5328, you also want to ensure that your test runs via Jenkins similar to how the quickstart tests are currently running. To do this you'll need to:
-
make a task which is capable of executing this StarterArchetype like:
-
add your task to the runJavaExamplesValidationTask:
Line 30 in a2b0ad1
(optional) As another follow-up, it would be nice to rename runJavaExamplesValidationTask to not be "examples" specific but something like runJavaPostReleaseTests. Might want to get an opinion from @alanmyrvold as to the name.
I'll merge this as is once the tests are green and allow you to open up follow-up PRs.
Member
|
retest this please |
ibzib
pushed a commit
to ibzib/beam
that referenced
this pull request
Apr 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed archetype-starter build script and provided an appropriate unit tests in accordance with: BEAM-5328
Post-Commit Tests Status (on master branch)