Skip to content

[BEAM-3018] Remove duplicated methods in StructuredCoder#3947

Merged
asfgit merged 1 commit intoapache:masterfrom
CaoManhDat:master
Oct 5, 2017
Merged

[BEAM-3018] Remove duplicated methods in StructuredCoder#3947
asfgit merged 1 commit intoapache:masterfrom
CaoManhDat:master

Conversation

@CaoManhDat
Copy link
Copy Markdown
Contributor

Removed consistentWithEquals(), structuralValue() and getEncodedTypeDescriptor() in StructuredCoder

@iemejia
Copy link
Copy Markdown
Member

iemejia commented Oct 5, 2017

R: @iemejia

@iemejia
Copy link
Copy Markdown
Member

iemejia commented Oct 5, 2017

retest this please

@coveralls
Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 8d8a213 on CaoManhDat:master into ** on apache:master**.

Copy link
Copy Markdown
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CaoManhDat !

@asfgit asfgit merged commit 8d8a213 into apache:master Oct 5, 2017
asfgit pushed a commit that referenced this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants