Skip to content

[BEAM-2596] Split Java and Python precommit jobs#3935

Merged
asfgit merged 1 commit intoapache:masterfrom
kennknowles:separate-precommits
Oct 4, 2017
Merged

[BEAM-2596] Split Java and Python precommit jobs#3935
asfgit merged 1 commit intoapache:masterfrom
kennknowles:separate-precommits

Conversation

@kennknowles
Copy link
Copy Markdown
Member

@kennknowles kennknowles commented Oct 3, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

This is to mitigate the issue of timeouts currently happening, until we can completely move to the pipeline build.

@kennknowles kennknowles force-pushed the separate-precommits branch 2 times, most recently from 4a3c65a to 7f4147e Compare October 3, 2017 17:22
@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 3, 2017

R: anyone, since the build remains perma-red/gray
Then also R: @jasonkuster to devise the right next steps

tgroh
tgroh reviewed Oct 4, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@tgroh tgroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any top-level job (seed job?) that you need to update? Any listeners you need to add?

.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
goals('''\
--batch-mode \
--errors \
--activate-profiles release,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner \
Copy link
Copy Markdown
Member

@tgroh tgroh Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 for long-form flags

.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
--batch-mode \
--errors \
--activate-profiles release,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner \
--projects sdks/java/core \
Copy link
Copy Markdown
Member

@tgroh tgroh Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there exist modules that will be written in java and part of our repository that will not depend on the core SDK; I'm not sure how to meaningfully catch them, though

Copy link
Copy Markdown
Member Author

@kennknowles kennknowles Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a great plan. I expect things to evolve from this crude step.

Copy link
Copy Markdown
Member

@tgroh tgroh Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is more important for the build pipeline stuff

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

I think we should run the seed job from this PR first to make sure it succeeds, so that we can always run it from master if it does not.

@tgroh
Copy link
Copy Markdown
Member

tgroh commented Oct 4, 2017

LGTM

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

Run Seed Job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

retest this please

kennknowles
kennknowles commented Oct 4, 2017
View reviewed changes
.test-infra/jenkins/job_beam_PreCommit_Python_MavenInstall.groovy Outdated
common_job_properties.setMavenConfig(delegate)

// Sets that this is a PreCommit job.
common_job_properties.setPreCommit(delegate, 'Maven clean install')
Copy link
Copy Markdown
Member Author

@kennknowles kennknowles Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tweak the message here

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

run seed job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

retest this please

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.05%) to 69.579% when pulling 4ae324f on kennknowles:separate-precommits into 9379ca2 on apache:master.

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

run seed job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

run seed job

@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

retest this please

@kennknowles kennknowles mentioned this pull request Oct 4, 2017
Merged
6 tasks
@kennknowles
Copy link
Copy Markdown
Member Author

kennknowles commented Oct 4, 2017

OK, I can confirm that the tests are launched as expected. Now either of them may end up red but that is a different breakage. Since the seed job has already adjusted Jenkins, I will merge this so the status in the repo reflects what is running.

@asfgit asfgit merged commit 25790a4 into apache:master Oct 4, 2017
asfgit pushed a commit that referenced this pull request Oct 4, 2017
@kennknowles
This closes #3935: [BEAM-2596] Split Java and Python precommit jobs
dee8e93
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.04%) to 69.576% when pulling 25790a4 on kennknowles:separate-precommits into 9379ca2 on apache:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.05%) to 69.579% when pulling 25790a4 on kennknowles:separate-precommits into 9379ca2 on apache:master.

@kennknowles kennknowles deleted the separate-precommits branch April 25, 2018 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgroh tgroh tgroh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kennknowles @tgroh @coveralls @asfgit