[BEAM-1037] Support for new State API in ApexRunner#3893
Merged
asfgit merged 1 commit intoapache:masterfrom Sep 30, 2017
Merged
[BEAM-1037] Support for new State API in ApexRunner#3893asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
0dd01bd to
ee39202
Compare
Member
|
run Apex ValidatesRunner |
kennknowles
approved these changes
Sep 29, 2017
Member
kennknowles
left a comment
There was a problem hiding this comment.
Simple and good. I kicked off the tests.
| stateBackend.newStateInternalsFactory(keyCoder)); | ||
| } else { | ||
| DoFnSignature signature = DoFnSignatures.getSignature(doFn.getClass()); | ||
| if (signature.stateDeclarations().size() > 0) { |
Member
There was a problem hiding this comment.
In review, someone suggested I add signature.usesState() to encapsulate this check. You could use it or not, I don't care so much.
ee39202 to
575e36e
Compare
asfgit
pushed a commit
that referenced
this pull request
Sep 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.R: @kennknowles