Conversation
25 tasks
Contributor
Author
|
R: @claudevdm or @Abacn (I think you both have some context). It would be good to get this in before release cut since this breaks GBEK for some scenarios |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36505 +/- ##
============================================
+ Coverage 55.08% 56.91% +1.83%
- Complexity 1666 3386 +1720
============================================
Files 1059 1221 +162
Lines 165352 186457 +21105
Branches 1190 3527 +2337
============================================
+ Hits 91080 106128 +15048
- Misses 72102 76972 +4870
- Partials 2170 3357 +1187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
claudevdm
approved these changes
Oct 15, 2025
stankiewicz
pushed a commit
to stankiewicz/beam
that referenced
this pull request
Oct 15, 2025
* Handle null keys in gbek * Allow null values with hashmap * add a test * Test + remove check entirely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed doing some broad validation that some transforms pass through a null key, and it triggers this condition, so this doesn't necessarily represent a decoding error like I initially thought. That should throw an exception anyways
Part of #36505
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.