Update python metrics example in programming guide#36334
Update python metrics example in programming guide#36334hjtran merged 5 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36334 +/- ##
============================================
+ Coverage 56.79% 56.83% +0.03%
Complexity 3385 3385
============================================
Files 1220 1220
Lines 185122 185580 +458
Branches 3508 3508
============================================
+ Hits 105148 105475 +327
- Misses 76649 76780 +131
Partials 3325 3325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Failures look unrelated |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
|
||
| metrics = result.metrics().query( | ||
| metrics.MetricsFilter.with_namespace("namespace").with_name("counter1")) | ||
| metrics_ = p.result.metrics().query( |
There was a problem hiding this comment.
Yeah I struggled to find a name that didn't overshadow the module name. I've changed it now to query_result
|
FYI, looks like we missed a license on the test file breaking precommits. #36386 should fix |
|
Thanks for the fix, sorry for missing it! |
It was non-functional and also used the older pipeline execution pattern.
Also added test that more or less mirrors the example to make sure it actually works.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.