Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

assign set of reviewers

Assigning reviewers:

R: @Abacn for label java.
R: @Abacn for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

please check the failed test

testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed

 but: The following disallowed classes appeared on the API surface:
	interface com.google.errorprone.annotations.CheckReturnValue exposed via:
		interface com.google.errorprone.annotations.CheckReturnValue

to fix, add "com.google.errorprone.annotations.CheckReturnValue" to

please check the failed test

testGcpApiSurface (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest) failed

 but: The following disallowed classes appeared on the API surface:
	interface com.google.errorprone.annotations.CheckReturnValue exposed via:
		interface com.google.errorprone.annotations.CheckReturnValue

to fix, add "com.google.errorprone.annotations.CheckReturnValue" to

beam/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java

Line 63 in 510d842

ImmutableSet.of(

Done. PTAL thanks!

Done. PTAL thanks!

Sorry if it wasn't clear. It is

Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),

not classesInPackage matchers. The latter was for packages. And the test will pass (checked locally)

checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1

Done. PTAL thanks!

Sorry if it wasn't clear. It is

Matchers.equalTo(com.google.errorprone.annotations.CheckReturnValue.class),

not classesInPackage matchers. The latter was for packages. And the test will pass (checked locally)

checked com.google.api.grpc:proto-google-cloud-spanner-v1 resolved to 6.95.1

Done. Thanks so much for the instructions.

Was the downgrade of netty required here? We would like to be at least on the version 118 final as it was before.

It got reverted by the tool due to GCP-BOM version was older. For GCP-BOM managed dependencies we generally avoid pin its versions