JDBCIO - handle empty driverjars argument#34514
Conversation
|
The original implementation was also resilient to empty string (driverJars="").
I get Could NPE happen somewhere else? |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
hey Yi, you are right, NPE is further down: when jarPath is empty string my guess is that |
|
Thanks for explanation, so the change makes the returned list from [""] to an empty list []. This LGTM |
handle empty string
YAML implementation passes default driver_jars: '' which is causing NPE in JDBCUtil.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.