Skip to content

Fix the case when update_compatibility_version is used without argument.#34083

Merged
Abacn merged 1 commit intoapache:masterfrom
shunping:fix-update-compatibility-version-option
Feb 26, 2025
Merged

Fix the case when update_compatibility_version is used without argument.#34083
Abacn merged 1 commit intoapache:masterfrom
shunping:fix-update-compatibility-version-option

Conversation

@shunping
Copy link
Copy Markdown
Collaborator

@shunping shunping commented Feb 26, 2025

Improve the handling of the update_compatibility_version option.

  • When the argument is not provided, the default value None is used.
  • Previously, using the argument as a standalone flag (e.g., --update_compatibility_version) resulted in an exception. This has been corrected to also resolve to None, aligning with the intended behavior.
  • Explicitly providing a version (e.g., --update_compatibility_version=2.63.0) will use that specified value.

(Internal bug id: 398402007, 399132073)

@shunping
Copy link
Copy Markdown
Collaborator Author

r: @Abacn

@shunping shunping requested a review from Abacn February 26, 2025 16:22
@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 69049e9 into apache:master Feb 26, 2025
86 checks passed
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants