Skip to content

Fix incorrect nullness in FlinkJobInvoker and JobInvoker#33713

Merged
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:FlinkJobInvoker
Apr 8, 2025
Merged

Fix incorrect nullness in FlinkJobInvoker and JobInvoker#33713
kennknowles merged 1 commit intoapache:masterfrom
kennknowles:FlinkJobInvoker

Conversation

@kennknowles
Copy link
Member

@kennknowles kennknowles commented Jan 22, 2025

Note that this is an actual error not just a hardening of the codebase: the retrievalToken is marked as required in the proto.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@kennknowles
Copy link
Member Author

kennknowles commented Jan 23, 2025

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@derrickaw
Copy link
Collaborator

derrickaw commented Mar 18, 2025

Hi @robertwb, please review when you have a chance. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2025

Reminder, please take a look at this pr: @robertwb

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@kennknowles
Copy link
Member Author

kennknowles commented Apr 3, 2025

R: @je-ik

@kennknowles
Copy link
Member Author

kennknowles commented Apr 3, 2025

I don't have time that I thought I would have to work on FlinkRunner right now, but I figure might as well get this tiny improvement checked in.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

je-ik
je-ik approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kennknowles kennknowles merged commit b1233b0 into apache:master Apr 8, 2025
20 checks passed
@kennknowles kennknowles deleted the FlinkJobInvoker branch April 8, 2025 15:37
akashorabek added a commit to akvelon/beam that referenced this pull request Apr 14, 2025
@akashorabek
Revert PR apache#33713
60fee6c
@akashorabek akashorabek mentioned this pull request Apr 14, 2025
Merged
3 tasks
Abacn pushed a commit that referenced this pull request Apr 14, 2025
@akashorabek
Fix The PostCommit XVR Flink job (#34628)
a699e8e 
* Revert PR #33713

* Run SpotlessJavaApply
@Abacn
Copy link
Contributor

Abacn commented Apr 14, 2025

This has been reverted in #34628 attempt to fix #31418 . The reason of breakage isn't clear but this appears to be the only flink runner related changes in the time range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@je-ik je-ik je-ik approved these changes

Assignees

No one assigned

Labels

flink Next Action: Reviewers runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kennknowles @derrickaw @Abacn @je-ik