Skip to content

Upgrade to new vendored grpc#33555

Merged
damccorm merged 14 commits intomasterfrom
users/damccorm/test-vendor-grpc
Jan 24, 2025
Merged

Upgrade to new vendored grpc#33555
damccorm merged 14 commits intomasterfrom
users/damccorm/test-vendor-grpc

Conversation

@damccorm
Copy link
Copy Markdown
Contributor

@damccorm damccorm commented Jan 9, 2025

Part 1/2 - once this is in I will remove the old vendored grpc artifacts


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Copy Markdown
Contributor Author

Failures so far:

/runner/_work/beam/beam/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/IsolationChannelTest.java:45: error: cannot find symbol
Iteration   1: 
import org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.NoopClientCall;
                                                           ^
  symbol:   class NoopClientCall
  location: package org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal

@damccorm
Copy link
Copy Markdown
Contributor Author

Failures so far:

/runner/_work/beam/beam/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/IsolationChannelTest.java:45: error: cannot find symbol
Iteration   1: 
import org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal.NoopClientCall;
                                                           ^
  symbol:   class NoopClientCall
  location: package org.apache.beam.vendor.grpc.v1p69p0.io.grpc.internal

Addressed the one real issue with 2d8cc11

@damccorm damccorm changed the title [Do not merge] Test upgrade vendored grpc Upgrade to new vendored grpc Jan 24, 2025
@damccorm damccorm marked this pull request as ready for review January 24, 2025 19:50
@damccorm
Copy link
Copy Markdown
Contributor Author

R: @Abacn

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Copy Markdown
Contributor

Abacn commented Jan 24, 2025

testOnNewWorkerMetadata_redistributesBudget known flaky test: #28957

@damccorm damccorm merged commit e7b4d63 into master Jan 24, 2025
@damccorm damccorm deleted the users/damccorm/test-vendor-grpc branch January 24, 2025 20:49
tomstepp pushed a commit to tomstepp/apache-beam that referenced this pull request Feb 3, 2025
* Vendor grpc

* Add settings.gradle.kts back

* test vendored grpc

* Update files to test

* Update imports

* Update BeamModulePlugin

* Fix snapshot version

* Inline NoopClientCall

* Fix conflicts

* remove leftover test repo pieces

* one more 60 -> 69

* one more 60 -> 69

* Fix version
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
* Vendor grpc

* Add settings.gradle.kts back

* test vendored grpc

* Update files to test

* Update imports

* Update BeamModulePlugin

* Fix snapshot version

* Inline NoopClientCall

* Fix conflicts

* remove leftover test repo pieces

* one more 60 -> 69

* one more 60 -> 69

* Fix version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants