Conversation
|
Precommit failures are unrelated, retrying but not blocking on them |
|
@aromanenko-dev here is another PR for aws v1 ios if you are around (I'll let the bot assign reviewers in case you are unavailable for the holidays 😄) |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
assign set of reviewers |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33455 +/- ##
=========================================
Coverage 57.43% 57.43%
Complexity 1474 1474
=========================================
Files 979 979
Lines 155295 155295
Branches 1076 1076
=========================================
Hits 89201 89201
Misses 63882 63882
Partials 2212 2212 ☔ View full report in Codecov by Sentry. |
ahmedabu98
left a comment
There was a problem hiding this comment.
LGTM! just a cleanup somewhere
...a/testing/load-tests/src/main/java/org/apache/beam/sdk/loadtests/SyntheticDataPublisher.java
Outdated
Show resolved
Hide resolved
* Remove aws v1 from infrastructure * Remove unused code
Part of #33430 to remove AWS v1 IOs entirely. This removes the v1 precommits and removes them from our infra used for load testing
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.