Conversation
2c56233 to
ba37c66
Compare
|
R: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
ba37c66 to
f0fd82e
Compare
damccorm
left a comment
There was a problem hiding this comment.
Left a few comments, but mostly they are minor - thanks!
f0fd82e to
60f01f3
Compare
87c452f to
13f3160
Compare
|
Minor (but useful) note - when you force push a rebase, it removes my ability to see the diff between what I reviewed previously and the current state 
So generally, please prefer just layering on additional commits in the PR and we can squash/merge at the end. Not really anything better about this workflow other than GitHub supports it better |
13f3160 to
9637269
Compare
damccorm
left a comment
There was a problem hiding this comment.
Thanks! One more minor comment, otherwise this LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33364 +/- ##
============================================
+ Coverage 57.40% 57.41% +0.01%
Complexity 1475 1475
============================================
Files 973 978 +5
Lines 154794 154935 +141
Branches 1076 1076
============================================
+ Hits 88854 88959 +105
- Misses 63737 63773 +36
Partials 2203 2203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
damccorm
left a comment
There was a problem hiding this comment.
Thanks - LGTM. The failing precommit seems to be related to flink, not this PR, so not blocking on that
* Add core RAG types. * Add chunking base. * Add LangChain TextSplitter chunking. * Add generic type support for embeddings. * Add base rag EmbeddingTypeAdapter. * Create HuggingfaceTextEmbeddings. * Linter fixes. * Docstring fixes. * Typehint fixes. * Docstring fix. * Add EmbeddingManager to args and more test coverage.
Add rag types, chunking and huggingface embeddings.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.