Skip to content

Add support for Iceberg table identifiers with special characters#33293

Merged
ahmedabu98 merged 4 commits intoapache:masterfrom
regadas:33292_ice_table_identifier
Jan 6, 2025
Merged

Add support for Iceberg table identifiers with special characters#33293
ahmedabu98 merged 4 commits intoapache:masterfrom
regadas:33292_ice_table_identifier

Conversation

@regadas
Copy link
Copy Markdown
Contributor

@regadas regadas commented Dec 5, 2024

This is a proposal that uses Json representation of Iceberg TableIdentifier to support special characters, more specifically, cases when tables contain a dot in the name.

Fixes: #33292

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@regadas regadas mentioned this pull request Dec 5, 2024
Closed
17 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@regadas
Copy link
Copy Markdown
Contributor Author

regadas commented Dec 5, 2024

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 13, 2024

Reminder, please take a look at this pr: @Abacn @Abacn

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 17, 2024

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@regadas
Copy link
Copy Markdown
Contributor Author

regadas commented Dec 19, 2024

@ahmedabu98 poking you here as well; I'll rebase this one soon

ahmedabu98
ahmedabu98 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

Can you trigger the integration tests here too?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 28, 2024

Reminder, please take a look at this pr: @kennknowles @johnjcasey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 1, 2025

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@ahmedabu98
Copy link
Copy Markdown
Contributor

ahmedabu98 commented Jan 1, 2025

waiting on author

@regadas regadas force-pushed the 33292_ice_table_identifier branch from 33add10 to 914e36a Compare January 4, 2025 09:05
@regadas regadas force-pushed the 33292_ice_table_identifier branch from 914e36a to 5f0e8c9 Compare January 6, 2025 16:47
@github-actions github-actions bot added build and removed build labels Jan 6, 2025
@ahmedabu98 ahmedabu98 merged commit d6e0b0c into apache:master Jan 6, 2025
@regadas
Copy link
Copy Markdown
Contributor Author

regadas commented Jan 6, 2025

Thanks for taking a look @ahmedabu98 🍻

claudevdm pushed a commit to claudevdm/beam that referenced this pull request Jan 10, 2025
Revert "Add support for Iceberg table identifiers with special charac…
dc47eff 
…ters (apache#33293)"

This reverts commit d6e0b0c.
Abacn added a commit to Abacn/beam that referenced this pull request Jan 13, 2025
@Abacn
Revert "Add support for Iceberg table identifiers with special charac…
237b60f 
…ters (apache#33293)"

This reverts commit d6e0b0c.
Abacn added a commit to Abacn/beam that referenced this pull request Jan 13, 2025
@Abacn
Revert "Add support for Iceberg table identifiers with special charac…
834812f 
…ters (apache#33293)"

This reverts commit d6e0b0c.
@Abacn Abacn mentioned this pull request Jan 13, 2025
Merged
3 tasks
Abacn added a commit that referenced this pull request Jan 14, 2025
@Abacn
Revert "Add support for Iceberg table identifiers with special charac…
bb2e0ad 
…ters (#33293)" (#33575)

This reverts commit d6e0b0c.
stankiewicz pushed a commit to stankiewicz/beam that referenced this pull request Jan 16, 2025
@regadas @stankiewicz
Add support for Iceberg table identifiers with special characters (ap…
dd11928 
…ache#33293)

* Add support for Iceberg table identifiers with special characters

* Add used undeclared dependencies

* Fix style

* Trigger iceberg integration tests
regadas added a commit to regadas/beam that referenced this pull request Jan 17, 2025
@regadas
Reapply "Add support for Iceberg table identifiers with special chara…
3a8d185 
…cters (apache#33293)" (apache#33575)

This reverts commit bb2e0ad.
@regadas regadas mentioned this pull request Jan 17, 2025
Closed
3 tasks
VardhanThigle pushed a commit to VardhanThigle/beam that referenced this pull request Mar 21, 2025
@Abacn @VardhanThigle
Revert "Add support for Iceberg table identifiers with special charac…
3aafd62 
…ters (apache#33293)" (apache#33575)

This reverts commit d6e0b0c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmedabu98 ahmedabu98 ahmedabu98 approved these changes

Assignees

No one assigned

Labels

io java Next Action: Reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for Iceberg table identifiers with special characters

2 participants

@regadas @ahmedabu98