Force kafka 3.1.2 for expansion-service jar#32703
Merged
Abacn merged 1 commit intoapache:masterfrom Oct 8, 2024
Merged
Conversation
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Contributor
Author
|
R: @Abacn |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Abacn
approved these changes
Oct 8, 2024
Contributor
|
Thanks! would you mind opening a chery-pick PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32703 +/- ##
============================================
- Coverage 58.85% 58.85% -0.01%
Complexity 3091 3091
============================================
Files 1130 1130
Lines 174108 174105 -3
Branches 3312 3312
============================================
- Hits 102465 102462 -3
Misses 68317 68317
Partials 3326 3326 ☔ View full report in Codecov by Sentry. |
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
damccorm
pushed a commit
that referenced
this pull request
Oct 9, 2024
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32623 was intended to package kafka-clients 3.1.2 into the expansion-service JAR, but gradle favors versions specified in groovy plugin module, so the version was being overridden with 2.4.1. This PR forces 3.1.2 to be used during runtime.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.